tests: add OGC self-touch crash case#79
Merged
Merged
Conversation
Author
|
For reference, I pushed a separate fix branch here: https://github.com/Filyus/iOverlay/tree/ogc-start-edge-contours That branch applies the start-edge end marker fix discussed above, scoped to OGC contour extraction: once traversal reaches the contour start node, it allows the already visited start link to be selected as the contour end marker, instead of treating the node itself as the end detector. Locally it passes:
Small note: the fix branch was developed with LLM assistance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a minimized regression test for the OGC extraction crash discussed in #78.
It intentionally contains only the test case, without a proposed fix, following the maintainer request in the previous PR thread.
Observed on current
main:cargo test --test crash_tests test_05 -- --nocapturefails withassertion failed: overlay_rule.is_fill_top(link.fill)inextract_ogc.rs.cargo test --release --test crash_tests test_05 -- --nocapturefails withindex out of bounds: the len is 40 but the index is 9223372036854775807.The input is the minimized 4-contour / 13-point case from the standalone reproducer.