Skip to content

added changes to max7456.c to add setting speed and removing spi_mod_0 flag with defines from target.h file #11396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DariaOrqa wants to merge 3 commits into
base: master
Choose a base branch
from
+27 −1
Open

added changes to max7456.c to add setting speed and removing spi_mod_0 flag with defines from target.h file #11396

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b183b3
added changes to max7456.c to add setting speed and removing spi_mode…
DariaOrqa Mar 4, 2026
ada5eb9
changed spacing and added static to function
DariaOrqa Mar 4, 2026
a294302
added bounds check for speed and fixed spi re-enable issue
DariaOrqa Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/main/drivers/max7456.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,31 @@ static int max7456PrepareBuffer(uint8_t * buf, size_t bufsize, int bufPtr, uint8
return bufPtr;
}

static void max7456ApplyBusSpeed(void)
{
#if defined(MAX7456_SPI_SPEED)
busSpeed_e speed = (MAX7456_SPI_SPEED <= BUS_SPEED_ULTRAFAST) ? MAX7456_SPI_SPEED : BUS_SPEED_STANDARD;
busSetSpeed(state.dev, speed);
#else
// Default safe speed for MAX7456
busSetSpeed(state.dev, BUS_SPEED_STANDARD);
#endif
}

// Used when standard DEVFLAGS_SPI_MODE_0 is omitted in common_hardware
static void max7456SpiModeOverride(void)
{
#if defined(STM32H7) && defined(MAX7456_MANUAL_SPI_CONFIG)
SPI_TypeDef *maxSpiInstance = spiInstanceByDevice(state.dev->busdev.spi.spiBus);
if (!maxSpiInstance){
return;
}

maxSpiInstance->CR1 &= ~SPI_CR1_SPE;
maxSpiInstance->CFG2 |= (SPI_CFG2_CPHA | SPI_CFG2_CPOL);
#endif
}

uint16_t max7456GetScreenSize(void)
{
// Default to PAL while the display is not yet initialized. This
Expand Down Expand Up @@ -386,7 +411,8 @@ void max7456Init(const videoSystem_e videoSystem)
return;
}

busSetSpeed(state.dev, BUS_SPEED_STANDARD);
max7456ApplyBusSpeed();
max7456SpiModeOverride();

// force soft reset on Max7456
busWrite(state.dev, MAX7456ADD_VM0, MAX7456_RESET);
Expand Down