Skip to content

cmake/sitl: use CheckLinkerFlag instead of GCC version check for --no-warn-rwx-segments #11383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sensei-hacker merged 2 commits into from
Mar 7, 2026
+5 −1
Merged

cmake/sitl: use CheckLinkerFlag instead of GCC version check for --no-warn-rwx-segments #11383

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa2fefc
cmake/sitl: use CheckLinkerFlag instead of GCC version check for --no…
sensei-hacker Mar 1, 2026
36bb13d
cmake/sitl: guard CheckLinkerFlag for compatibility with CMake < 3.18
sensei-hacker Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmake/sitl.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ if(NOT MACOSX)
-Wno-error=maybe-uninitialized
-fsingle-precision-constant
)
if (CMAKE_COMPILER_IS_GNUCC AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 12.0)
include(CheckLinkerFlag)
check_linker_flag(C "-Wl,--no-warn-rwx-segments" LINKER_SUPPORTS_NO_RWX_WARNING)
Comment thread
sensei-hacker marked this conversation as resolved.
Outdated
if(LINKER_SUPPORTS_NO_RWX_WARNING)
set(SITL_LINK_OPTIONS ${SITL_LINK_OPTIONS} "-Wl,--no-warn-rwx-segments")
endif()
else()
Expand Down