Fix ICM42688 bus device hardware type on GEPRC targets#11377
Open
sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
Open
Fix ICM42688 bus device hardware type on GEPRC targets#11377sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
sensei-hacker wants to merge 1 commit intoiNavFlight:maintenance-9.xfrom
Conversation
The ICM42688 gyro on IMU1 was registered with DEVHW_MPU6000 instead of DEVHW_ICM42605, preventing the ICM42605 driver from detecting it. Boards populated with ICM42688 chips would fail to detect the primary gyro. The IMU2 registration was already correct. Affected targets: GEPRC_TAKER_H743, GEPRCF745_BT_HD Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Fix incorrect
DEVHW_MPU6000hardware type constant for ICM42688 gyro registration on IMU1 for two GEPRC targets. The ICM42688 should be registered withDEVHW_ICM42605(the ICM42605 driver handles both ICM42605 and ICM42688). This was a copy-paste error from the MPU6000 registration line above.Without this fix, boards populated with ICM42688 chips on IMU1 would fail gyro detection because the ICM42605 driver searches for
DEVHW_ICM42605, notDEVHW_MPU6000. The IMU2 registration on line 33 was already correct.Changes
GEPRC_TAKER_H743/target.cline 32:DEVHW_MPU6000→DEVHW_ICM42605GEPRCF745_BT_HD/target.cline 32:DEVHW_MPU6000→DEVHW_ICM42605Testing
Code Review
Reviewed with inav-code-review — no issues found. The fix is a single-token change per file, consistent with the already-correct IMU2 registration pattern.
PR Type
Bug fix
Description
Corrects ICM42688 hardware type constant from DEVHW_MPU6000 to DEVHW_ICM42605
Fixes gyro detection failure on IMU1 for two GEPRC targets
Aligns IMU1 registration with already-correct IMU2 pattern
Diagram Walkthrough
File Walkthrough
target.c
Fix ICM42688 IMU1 hardware type constantsrc/main/target/GEPRCF745_BT_HD/target.c
DEVHW_MPU6000toDEVHW_ICM42605detecting the sensor
target.c
Fix ICM42688 IMU1 hardware type constantsrc/main/target/GEPRC_TAKER_H743/target.c
DEVHW_MPU6000toDEVHW_ICM42605detecting the sensor