feat(docker-build): add security report option and upload step#37
Merged
TartanLeGrand merged 1 commit intomainfrom Apr 24, 2025
Merged
feat(docker-build): add security report option and upload step#37TartanLeGrand merged 1 commit intomainfrom
TartanLeGrand merged 1 commit intomainfrom
Conversation
Le-Caignec
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
.github/workflows/docker-build.ymlfile to enhance security reporting capabilities by introducing a new input parameter and associated actions. The most important changes include adding support for asecurity-reportinput, modifying conditions for existing steps, and introducing a new step to upload SARIF files to GitHub's Security tab.Enhancements to security reporting:
security-reportinput parameter with a default value of'sarif'and typestring. This allows users to specify the desired format for security scan results. ([.github/workflows/docker-build.ymlR22-R25](https://github.com/iExecBlockchainComputing/github-actions-workflows/pull/37/files#diff-3414847e2ad632333f775cabb810f0dc0df61a570365df34750a08b00912fe82R22-R25))security-report == 'comment'in addition to the existing conditions. ([.github/workflows/docker-build.ymlL103-R107](https://github.com/iExecBlockchainComputing/github-actions-workflows/pull/37/files#diff-3414847e2ad632333f775cabb810f0dc0df61a570365df34750a08b00912fe82L103-R107))security-report == 'sarif'. This step uses thegithub/codeql-action/upload-sarif@v3action. ([.github/workflows/docker-build.ymlR130-R135](https://github.com/iExecBlockchainComputing/github-actions-workflows/pull/37/files#diff-3414847e2ad632333f775cabb810f0dc0df61a570365df34750a08b00912fe82R130-R135))