Skip to content

Fix/doc #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TartanLeGrand merged 2 commits into from
Apr 4, 2025
Merged

Fix/doc #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
799666a
feat: make NPM package scope optional with default value
Le-Caignec Apr 4, 2025
01937e0
docs: update README to reflect optional NPM package scope and default…
Le-Caignec Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/publish-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ on:
workflow_call:
inputs:
scope:
description: 'NPM package scope (e.g., @iExecBlockchainComputing)'
required: true
description: 'NPM package scope (e.g., @iexec)'
required: false
default: '@iexec'
type: string
node-version:
description: 'Node.js version to use'
Expand Down
6 changes: 2 additions & 4 deletions publish-npm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This reusable GitHub Actions workflow automates the process of publishing an NPM

| **Input** | **Description** | **Required** | **Default** |
|-------------------|-----------------------------------------------------------------------------------------------|--------------|--------------------------------------|
| **scope** | Defines the NPM package scope (e.g., `@iExecBlockchainComputing`). | Yes | – |
| **scope** | Defines the NPM package scope (e.g., `@iexec`). | No | `@iexec` |
| **node-version** | Specifies the Node.js version to use. | No | `20` |
| **registry** | URL of the NPM registry. | No | `https://registry.npmjs.org` |
| **access** | Package access level (public or restricted). | No | `public` |
Expand Down Expand Up @@ -56,9 +56,7 @@ This reusable GitHub Actions workflow automates the process of publishing an NPM
publish:
uses: your-org/your-repo/.github/workflows/publish-npm.yml@main
with:
scope: '@iExecBlockchainComputing'
node-version: '20'
registry: 'https://registry.npmjs.org'
node-version: '22'
secrets:
npm-token: ${{ secrets.NPM_TOKEN }}
```
Expand Down