Skip to content

Conversation

@ErwanDecoster
Copy link
Member

@ErwanDecoster ErwanDecoster commented Dec 19, 2025

Note

Improves accessibility and semantics across multiple components.

  • Adds explicit aria-labels to interactive elements (Navbar, Footer social links, CopyButton, AddressChip, SmartLinkGroup, SchemaSearch, logout buttons, mobile menu toggle)
  • Introduces proper roles and states (Tabs: role="tablist", buttons as role="tab" with aria-selected; ModeToggle uses clearer aria-label)
  • Enhances search field semantics (type="search", aria-describedby for errors, role="alert" + aria-live="polite" for error messages) and makes the search button accessible on small screens
  • Sets type="button" where needed to prevent unintended form submits
  • Improves link/logo semantics (Home links get aria-label="Home"; decorative logos use empty alt)
  • Minor: comment clarifies desktop pagination logic

Written by Cursor Bugbot for commit e0bcb11. This will update automatically on new commits. Configure here.

ErwanDecoster and others added 29 commits October 15, 2025 11:24
…al count for apps, datasets, and workerpools
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…k Explorer link in SmartLinkGroup; add role to Tabs component
@ErwanDecoster ErwanDecoster self-assigned this Dec 19, 2025
@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
explorer-v2 Ready Ready Preview, Comment Jan 28, 2026 10:54am

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements accessibility improvements across the application with the following key changes:

  • Adds new "ACCESS" tabs to workerpool, dataset, and app detail pages showing access/orderbook information
  • Implements ARIA labels, roles, and descriptions for better screen reader support
  • Refactors loading and outdated state management to bubble up from child components
  • Adds semantic HTML attributes (type="search", role="searchbox", aria-live regions)
  • Updates the iexec package from 8.18.0 to 8.20.0

Reviewed changes

Copilot reviewed 39 out of 40 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/routes/$chainSlug/_layout/workerpool/$workerpoolAddress.tsx Added ACCESS tab with WorkerpoolAccessTable component and state management
src/routes/$chainSlug/_layout/dataset/$datasetAddress.tsx Added ACCESS tab with DatasetAccessTable component and state management
src/routes/$chainSlug/_layout/app/$appAddress.tsx Added ACCESS tab with AppAccessTable component and state management
src/routes/$chainSlug/_layout/address/$addressAddress.tsx Added ACCESS tab showing all three access tables
src/modules/workerpools/workerpool/WorkerpoolDealsTable.tsx Refactored to use props for loading/outdated state, fixed typo in error message
src/modules/workerpools/workerpool/WorkerpoolAccessTable.tsx New component for displaying workerpool access orderbook
src/modules/datasets/dataset/DatasetDealsTable.tsx Refactored to use props for loading/outdated state, fixed typo in error message
src/modules/datasets/dataset/DatasetAccessTable.tsx New component for displaying dataset access orderbook
src/modules/apps/app/AppDealsTable.tsx Refactored to use props for loading/outdated state, fixed typo in error message
src/modules/apps/app/AppAccessTable.tsx New component for displaying app access orderbook
src/modules/search/SearcherBar.tsx Added ARIA attributes for search input and error messages
src/modules/datasets/SchemaSearch.tsx Added ARIA labels to filter buttons
src/modules/Tabs.tsx Added role="radio" to tab buttons
src/components/navbar/NavBar.tsx Added aria-label to links and buttons, changed logo alt text
src/components/Footer.tsx Added aria-label to social media links
src/components/PaginatedNavigation.tsx Improved pagination logic and stability
src/components/ModeToggle.tsx Enhanced aria-label for theme toggle
src/components/CopyButton.tsx Added aria-label and type attribute
package.json Updated iexec from 8.18.0 to 8.20.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment needed on id, see comments, feel free to merge once resolved

…ibility for tabs adding missing aria-selected attribute
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@Christophe-iExec Christophe-iExec merged commit 50dd330 into main Jan 28, 2026
8 checks passed
@Christophe-iExec Christophe-iExec deleted the feature/better-accessibility branch January 28, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants