Skip to content

fix: missing address tabs #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErwanDecoster merged 3 commits into from
Dec 9, 2025
Merged

fix: missing address tabs #107

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9672ef9
fix: missing address tabs
ErwanDecoster Dec 9, 2025
cf658c0
fix: handle null or undefined account value
ErwanDecoster Dec 9, 2025
f0282cf
style: format addressDetails assignment for better readability
ErwanDecoster Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/routes/$chainSlug/_layout/address/$addressAddress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ function AddressRoute() {
const { chainId, address: userAddress } = useUserStore();
const { addressAddress } = Route.useParams();
const {
data: address,
data: account,
Comment thread
ErwanDecoster marked this conversation as resolved.
isLoading,
isRefetching,
isError,
Expand Down Expand Up @@ -119,16 +119,16 @@ function AddressRoute() {
}
}, [userAddress, addressAddress, fromMyActivity, navigate, chainSlug]);

const addressDetails = address ? buildAddressDetails({ address }) : undefined;
const addressOverview = address
? buildAddressOverview({ address })
const addressDetails = buildAddressDetails({ address: account });
Comment thread
ErwanDecoster marked this conversation as resolved.
Outdated
const addressOverview = account
? buildAddressOverview({ address: account })
: undefined;

if (!isValid) {
return <ErrorAlert className="my-16" message="Invalid address." />;
}

if (isError && error && address === null) {
if (isError && error && account === null) {
return (
<ErrorAlert className="my-16" message="No data found for this address." />
);
Expand All @@ -142,7 +142,7 @@ function AddressRoute() {
<h1 className="flex items-center gap-2 font-sans text-2xl font-extrabold">
<AddressIcon size={24} />
Address details
{!address && isError && (
{!account && isError && (
<span className="text-muted-foreground text-sm font-light">
(outdated)
</span>
Expand All @@ -160,7 +160,7 @@ function AddressRoute() {

<AddressTabsContent
addressAddress={addressAddress}
address={addressDetails}
address={account ?? undefined}
addressDetails={addressDetails}
addressOverview={addressOverview}
hasPastError={hasPastError}
Expand Down
Loading