Skip to content

Support transparancy in toplevel export#12824

Merged
vaxerski merged 4 commits intohyprwm:mainfrom
ArchSav:toplevel-export-transparancy
Jan 20, 2026
Merged

Support transparancy in toplevel export#12824
vaxerski merged 4 commits intohyprwm:mainfrom
ArchSav:toplevel-export-transparancy

Conversation

@ArchSav
Copy link
Copy Markdown
Contributor

@ArchSav ArchSav commented Jan 3, 2026

Describe your PR, what does it fix/add?

Clears buffer with transparent pixels instead of black when copying a surface with toplevel export.

closes #11192

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I am unsure whether tests are necessary for this pr due to it being rendering related

Is it ready for merging, or does it need work?

yes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 3, 2026

Hello and thank you for making a PR to Hyprland!

Please check the PR Guidelines and make sure your PR follows them.
It will make the entire review process faster. :)

If your code can be tested, please always add tests. See more here.

beep boop, I'm just a bot. A real human will review your PR soon.

Comment thread src/helpers/Monitor.cpp Outdated
@ArchSav ArchSav force-pushed the toplevel-export-transparancy branch from 3a2c560 to bbc6245 Compare January 4, 2026 00:15
@ArchSav ArchSav marked this pull request as draft January 4, 2026 00:15
@ArchSav ArchSav marked this pull request as ready for review January 4, 2026 04:41
Comment thread src/helpers/Format.cpp Outdated
@ArchSav ArchSav force-pushed the toplevel-export-transparancy branch from 1df0347 to 3abdc1d Compare January 16, 2026 07:55
@ArchSav
Copy link
Copy Markdown
Contributor Author

ArchSav commented Jan 16, 2026

Sorry change took so long to happen

@ArchSav ArchSav force-pushed the toplevel-export-transparancy branch from 3abdc1d to d42ff25 Compare January 16, 2026 22:15
vaxerski
vaxerski previously approved these changes Jan 17, 2026
Comment thread src/helpers/Format.cpp Outdated
Copy link
Copy Markdown
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtv

@vaxerski vaxerski merged commit c44292c into hyprwm:main Jan 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve transparency with toplevel export

2 participants