config/input: Invert movement for all pointer devices, not just touchpads#12560
Open
m-matovic wants to merge 3 commits intohyprwm:mainfrom
Open
config/input: Invert movement for all pointer devices, not just touchpads#12560m-matovic wants to merge 3 commits intohyprwm:mainfrom
m-matovic wants to merge 3 commits intohyprwm:mainfrom
Conversation
vaxerski
reviewed
Dec 9, 2025
Member
vaxerski
left a comment
There was a problem hiding this comment.
keep touchpad, don't break. Fall back to global if touchpad is unset.
Author
|
I am a bit unclear on why touchpads had these properties unique to them? If they're just pointers with a size, why does having a size make them elligible for flipping but other pointers not? Is it not more straightforward to leave the flip config options in global scope and load them for all pointers? They can be overriden in per-device configs. I will return the isTouchpad property in any case, even if it's left unused right now. Will make changes tonight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Use
m_flipX/m_flipYto invert movement for all pointer devices, not just touchpads.Move the
flip_x/flip_yconfig options frominput::touchpadtoinputand load them for all pointer devices.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
If the changes are merged, the wiki page Configuring/Variables should be update accordingly (I'll do it).
Is it ready for merging, or does it need work?
Ready