fix(core): make CosmosSigningOptions.cosmosSignerConfig partial#41
Merged
pyramation merged 1 commit intohyperweb-io:mainfrom Mar 27, 2026
Merged
fix(core): make CosmosSigningOptions.cosmosSignerConfig partial#41pyramation merged 1 commit intohyperweb-io:mainfrom
pyramation merged 1 commit intohyperweb-io:mainfrom
Conversation
34e0ba0 to
2bbb374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
CosmosSigningOptions.cosmosSignerConfigwas typed as fullCosmosSignerConfig, but callers may want to only provideDocOptionsfields (e.g.gasPrice,encodePublicKey,pubkeyDecoders) withoutqueryClient, which is injected internally bygetSigningClient():interchain-kit/packages/core/src/wallet-manager.ts
Lines 257 to 262 in dcdabc8
Description
Changed
cosmosSignerConfigtoPartial<CosmosSignerConfig>to match actual usage.