Skip to content

fix(core): make CosmosSigningOptions.cosmosSignerConfig partial#41

Merged
pyramation merged 1 commit intohyperweb-io:mainfrom
2wheeh:fix/partial-props
Mar 27, 2026
Merged

fix(core): make CosmosSigningOptions.cosmosSignerConfig partial#41
pyramation merged 1 commit intohyperweb-io:mainfrom
2wheeh:fix/partial-props

Conversation

@2wheeh
Copy link
Copy Markdown
Contributor

@2wheeh 2wheeh commented Mar 27, 2026

Background

CosmosSigningOptions.cosmosSignerConfig was typed as full CosmosSignerConfig, but callers may want to only provide DocOptions fields (e.g. gasPrice, encodePublicKey, pubkeyDecoders) without queryClient, which is injected internally by getSigningClient():

const signerOptions: CosmosSignerConfig = {
queryClient: await createCosmosQueryClient(rpcEndpoint as string),
addressPrefix: chain.bech32Prefix,
chainId: chain.chainId,
...defaultSignerOptions.cosmosSignerConfig,
};

Description

Changed cosmosSignerConfig to Partial<CosmosSignerConfig> to match actual usage.

@2wheeh 2wheeh force-pushed the fix/partial-props branch from 34e0ba0 to 2bbb374 Compare March 27, 2026 06:02
@2wheeh 2wheeh changed the title fix(core): make SignerOptions signing return Partial fix(core): make CosmosSigningOptions.cosmosSignerConfig partial Mar 27, 2026
@pyramation pyramation merged commit bb67795 into hyperweb-io:main Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants