Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## Description

Please include a summary of the change, motivation and context.

<!--
Expand All @@ -7,16 +8,18 @@ Please include a summary of the change, motivation and context.
- **on a bugfix**: link relevant information about the bug (github issue or slack thread) and how this change solves it e.g. this change fixes #99999 by adding a lock on read/write to avoid data races.
-->


### Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

### Checklist:

- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] Any dependent changes have been merged and published in downstream modules

### Documentation

Make sure that you have documented corresponding changes in this repository or [hypertrace docs repo](https://github.com/hypertrace/hypertrace-docs-website) if required.

<!--
Expand Down
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ updates:
- package-ecosystem: 'npm'
directory: '/'
commit-message:
prefix: "chore"
prefix: 'chore'
schedule:
interval: 'weekly'
5 changes: 4 additions & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
npx --no-install pretty-quick --staged
FILES=$(git diff --cached --name-only --diff-filter=ACMR)
[ -z "$FILES" ] && exit 0
echo "$FILES" | xargs npx --no-install oxfmt
echo "$FILES" | xargs git add
9 changes: 9 additions & 0 deletions .oxfmtrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"$schema": "./node_modules/oxfmt/configuration_schema.json",
"singleQuote": true,
"printWidth": 120,
"trailingComma": "none",
"arrowParens": "avoid",
"sortPackageJson": false,
"ignorePatterns": []
}
6 changes: 0 additions & 6 deletions .prettierrc

This file was deleted.

10 changes: 6 additions & 4 deletions CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,10 @@ Core `@hypertrace/hyperdash` classes are wrapped as Angular injectable services

### Module System

- `DashboardCoreModule`: Main runtime module with default property types and deserializers
- All library components, directives, and pipes are **standalone**
- `DashboardCoreModule`: Re-exports standalone declarables with default property types and deserializers
- `DashboardCoreModule.with(metadata)`: Extend with custom types, models, renderers, editors, deserializers
- `DashboardEditorModule`: Separate module for editing capabilities
- `DashboardEditorModule`: Re-exports standalone editor components

### Key Injection Tokens

Expand Down Expand Up @@ -69,15 +70,16 @@ Core `@hypertrace/hyperdash` classes are wrapped as Angular injectable services

### Testing

- Jest with `@ngneat/spectator` for component testing
- Vitest via `@angular/build:unit-test` (zoneless, AOT)
- Test files: `*.test.ts` or `*.spec.ts`
- Coverage excludes: `*.module.ts`, `public_api.ts`, `test/` directory
- Zoneless requires `fixture.changeDetectorRef.markForCheck()` before `fixture.detectChanges()` when mutating component properties between change detection cycles

### Commits

- Conventional commits required (enforced via commitlint)
- Use `npm run commit` for interactive commit wizard
- Pre-commit hook runs Prettier on staged files
- Pre-commit hook runs oxfmt on staged files

## ESLint Rules of Note

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ Run `npm start` for a dev server. Navigate to `http://localhost:4200/`. The app

## Running unit tests

Run `npm run test` to execute the unit tests via Jest
Run `npm run test` to execute the unit tests via Vitest

## Commit

Run `npm commit` and follow the prompts provided to create a properly formatted commit
Run `npm run commit` and follow the prompts provided to create a properly formatted commit
19 changes: 15 additions & 4 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,12 @@
}
},
"test": {
"builder": "@angular-builders/jest:run",
"builder": "@angular/build:unit-test",
"options": {
"detectOpenHandles": true
"buildTarget": "hyperdash-angular-app:build",
"tsConfig": "tsconfig.spec.json",
"runner": "vitest",
"reporters": ["default", ["junit", { "outputFile": "test-results/hyperdash-angular-app/results.xml" }]]
}
},
"lint": {
Expand Down Expand Up @@ -110,8 +113,16 @@
}
},
"test": {
"builder": "@angular-builders/jest:run",
"options": {}
"builder": "@angular/build:unit-test",
"options": {
"buildTarget": "hyperdash-angular:build",
"tsConfig": "projects/hyperdash-angular/tsconfig.spec.json",
"runner": "vitest",
"coverage": true,
"coverageInclude": ["projects/hyperdash-angular/src/**/*.ts"],
"coverageExclude": ["**/*.module.ts", "**/public_api.ts", "projects/hyperdash-angular/src/test/**"],
"reporters": ["default", ["junit", { "outputFile": "test-results/hyperdash-angular/results.xml" }]]
}
},
"lint": {
"builder": "@angular-eslint/builder:lint",
Expand Down
11 changes: 0 additions & 11 deletions jest.config.debug.js

This file was deleted.

23 changes: 0 additions & 23 deletions jest.config.js

This file was deleted.

Loading