Conversation
adkozlov
force-pushed
the
adkozlov/ALT-10993
branch
2 times, most recently
from
6c06773 to
57b15bc
Compare
adkozlov
force-pushed
the
adkozlov/ALT-10993
branch
from
57b15bc to
439f7d0
Compare
* ALT-10995 cleanFileLevelHighlights moved to EDT * ALT-10995 unnecessary for loop removed * ALT-10995 running CI with push events * fixup! ALT-10995 running CI with push events This reverts commit 483f50a. * fixup! ALT-10995 unnecessary for loop removed
meanmail
reviewed
Mar 17, 2026
Contributor
meanmail
left a comment
meanmail
left a comment
There was a problem hiding this comment.
Review
Overall the PR looks solid for adding 261 platform support. Nice cleanup of the secret properties mechanism and good use of branch-specific compatibility abstractions.
Main concern: potential bug in JdkLanguageSettings where loadingState gets unconditionally overwritten — see inline comment.
Minor items:
- Several new files are missing a trailing newline (
MergeDialogCustomizerCompat.kt,MergeModelBaseCompat.kt,oauth.properties) CppGEduTaskChecker.ktin branches 252 and 253 importsEnvironmentCheckerbut doesn't use it directlyCppCatchEduTaskChecker.ktandCppGEduTaskChecker.ktare identical between 252 and 253 branches — could potentially share code- BACKCOMPAT comment in
branches/261/.../csharp/compatibilityUtils.ktsays "BACKCOMPAT 261" but the API change happened in 253
intellij-plugin/hs-jvm-core/src/org/hyperskill/academy/jvm/JdkLanguageSettings.kt
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@meanmail Please see the changes and approve. |
meanmail
approved these changes
Mar 17, 2026
Contributor
meanmail
left a comment
meanmail
left a comment
There was a problem hiding this comment.
All review comments have been addressed. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.