Skip to content

Campaign 253/migrate fogbinder deno - #37

Open
hyperpolymath wants to merge 15 commits into
mainfrom
campaign-253/migrate-fogbinder-deno
Open

Campaign 253/migrate fogbinder deno#37
hyperpolymath wants to merge 15 commits into
mainfrom
campaign-253/migrate-fogbinder-deno

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (would change existing behaviour)
  • 🕳️ Soundness fix (fixes a checker/proof false-negative)
  • 📖 Documentation
  • 🧹 Refactor / tech debt (behaviour-preserving)
  • ⚡ Performance
  • 🔧 Build / CI / tooling

How has this been verified?

Checklist

  • My commits are signed (git commit -S).
  • I ran the project's own checks/tests locally and they pass.
  • New files carry the correct SPDX-License-Identifier (code/config MPL-2.0,
    prose CC-BY-SA-4.0); I did not relicense existing files.
  • Docs are updated, and no public claim now overstates what the code does.
  • I have not introduced a soundness hole (or I have flagged where I might have).

Notes for reviewers


Summary by Gitar

  • CI/CD & Workflows:
    • Adopted standard reusable workflows for Scorecard, Hypatia, and Governance across packages
    • Standardized secret scanning on TruffleHog across all CI pipelines
  • Contractiles & Metadata:
    • Replaced old contractiles with new canonical Intentfile.a2ml, Mustfile.a2ml, Trustfile.a2ml, and Adjustfile.a2ml
  • Governance & Docs:
    • Added comprehensive GOVERNANCE.adoc and CODEOWNERS configuration
  • Refactoring:
    • Renamed agent instruction directories to bot_directives for spec alignment

This will update automatically on new commits.

hyperpolymath and others added 15 commits May 30, 2026 21:56
Class B (npm-wrapper via Deno) — simplest case. Deletes
package.json stub (rescript-toolchain devDeps only, zero scripts,
private:true). deno.json carries npm:rescript via imports map.

Refs: standards#253 STEP 3 (smallest-first batch).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- C001: CodeQL language fixes
- C002: License identifier standardization
- C003: Outdated actions audit
- C004: Pin standards refs to SHA 861b5e9
- C005: Add workflow-level permissions
- grant secret-scanner reusable its requested job permissions
- drop invalid timeout-minutes on reusable-call jobs
- drop hashFiles() from job-level if: expressions
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@gitar-bot

gitar-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review ✅ Approved

Estate-wide CI standardization updates workflows to use reusable templates for Scorecard, Hypatia, and Governance, adds secret scanning via TruffleHog, and establishes governance documentation. No issues found.

Auto-approved and auto-merge armed: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria. — merges when pipeline and required approvals pass.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot

gitar-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

⚠️ Gitar auto-approved this PR but could not enable auto-merge: auto-merge is disabled for this repository — enable "Allow auto-merge" in the repository settings.

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR and enabled auto-merge (configure)

@gitar-bot gitar-bot Bot added the gitar-approved Added by Gitar label Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitar-approved Added by Gitar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants