fix(estate-rules): allowlist .githooks/, drop the stale flake.nix entry - #36
Conversation
Two root-allowlist corrections; estate-rules has been red on main since #31. 1. `.githooks/` arrived with PR #31 (vendored A2ML/K9 validators run by the dogfood gate) but was never added to .machine_readable/root-allow.txt, so "Root shape allowlist" fails with "1 root entries are not on the allowlist". Added with justification, which is exactly what the gate's own error message prescribes -- the directory is genuinely root-bound (git's core.hooksPath convention, and dogfood-gate.yml invokes `bash .githooks/validate-*.sh`). 2. Removed the stale `flake.nix` line. That file was deleted under the Guix-only ruling; an allowlist entry for an absent path is dead weight that invites someone to re-add the file thinking it is sanctioned. Verified: scripts/check-root-shape.sh passes locally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedAllowlists the .githooks/ directory in estate-rules and removes the stale flake.nix entry, resolving check-root-shape failures on main. No issues found.
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
1 participant
estate-ruleshas been red on main since #31:.githooks/(the vendored validators the dogfood gate now runs) was never added to the root allowlist. Added with justification — the gate's own error message prescribes this. Also drops the staleflake.nixentry, since that file was deleted under the Guix-only ruling and a sanctioned-looking allowlist line invites its return.scripts/check-root-shape.shpasses locally.