Fix/panicbot colon filename - #456
Conversation
…guard Panicbot Sweep failed 3 consecutive weekly runs (06-14/06-21/06-28): actions/upload-artifact rejects ':' in paths, and one legacy file (shared-context/findings/indieweb2-bastion/2026-02-14T00:00:00Z.json — the only colon path in the tree) failed the whole sweep's artifact upload. The writer (scripts/submit-finding.sh) already emits colon-free names (%Y%m%d-%H%M%S), so the file is residue from an older path, not a live writer bug — renamed to 2026-02-14T00-00-00Z.json. Added a fail-loud pre-upload guard that names any future offender instead of letting the upload step fail cryptically (fail loudly; the guard points at the writer). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- grant secret-scanner reusable its requested job permissions - drop invalid timeout-minutes on reusable-call jobs - drop hashFiles() from job-level if: expressions
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedAdds a fail-loud filename guard against colon-named finding files in panicbot-sweep.yml and updates secret-scanner job permissions. No issues found.
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
1 participant
Summary
Closes #
Type of change
How has this been verified?
Checklist
git commit -S).SPDX-License-Identifier(code/configMPL-2.0,prose
CC-BY-SA-4.0); I did not relicense existing files.Notes for reviewers
Summary by Gitar
panicbot-sweep.ymlto fail on artifact-illegal colon-named finding filessecret-scanner.ymlThis will update automatically on new commits.