Skip to content

Fix/remove trailing semicolon fixer - #455

Merged
hyperpolymath merged 4 commits into
mainfrom
fix/remove-trailing-semicolon-fixer
Jul 29, 2026
Merged

Fix/remove trailing semicolon fixer#455
hyperpolymath merged 4 commits into
mainfrom
fix/remove-trailing-semicolon-fixer

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (would change existing behaviour)
  • 🕳️ Soundness fix (fixes a checker/proof false-negative)
  • 📖 Documentation
  • 🧹 Refactor / tech debt (behaviour-preserving)
  • ⚡ Performance
  • 🔧 Build / CI / tooling

How has this been verified?

Checklist

  • My commits are signed (git commit -S).
  • I ran the project's own checks/tests locally and they pass.
  • New files carry the correct SPDX-License-Identifier (code/config MPL-2.0,
    prose CC-BY-SA-4.0); I did not relicense existing files.
  • Docs are updated, and no public claim now overstates what the code does.
  • I have not introduced a soundness hole (or I have flagged where I might have).

Notes for reviewers


Summary by Gitar

  • Bug fixes & CI:
    • Removed stray semicolon in fixer.rs so expand_template returns String and fixes clippy compile error
    • Updated CI workflow configurations and contained Dependabot PR fan-out

This will update automatically on new commits.

hyperpolymath and others added 4 commits July 29, 2026 00:50
check_suite:[completed] and workflow_run:[completed] made this workflow fire
once per CI completion on every watched workflow -- a multiplier on every unit
of estate CI activity, and the mechanism behind the notification burst of
2026-07-20/21 (measured: 3,041 CheckSuite notifications inside a ~19-hour
window, and none since).

The workflow is currently disabled_manually, which is why the burst stopped.
That makes the risk latent rather than resolved: these triggers plus
contents:write / pull-requests:write mean re-enabling it would restart the
multiplier. Removing them so re-enabling is safe.

pull_request, pull_request_review and workflow_dispatch are retained -- the
monitoring path the workflow was neutered down to in 2026-06 is untouched.

Verified: YAML parses and the trigger map is now exactly
pull_request, pull_request_review, workflow_dispatch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…em repos

dogfood-gate.yml pinned hyperpolymath/a2ml-validate-action and
hyperpolymath/k9-validate-action. Both repositories are DELETED (verified 404).
An unresolvable uses: ref produces NO check run at all -- not a red one -- so
'Validate A2ML manifests' and 'Validate K9 contracts' could never report, and
any ruleset requiring them was unsatisfiable. That is what blocked this very PR.

The actions were not lost, they MOVED:
  hyperpolymath/a2ml-ecosystem/validate-action  (action.yml verified at the pin)
  hyperpolymath/k9-ecosystem/validate-action    (action.yml verified at the pin)

Repointed rather than vendored. The estate handover proposed vendoring the
scripts into ~272 consumer repos; that would create 272 copies to drift, which
the same document names as this estate's most recurring failure mode. Repointing
is one line per file and keeps a single source.

SHAs are the ones already proven green in the-nash-equilibrium#83; both verified
to resolve (2026-07-25) and to contain validate-action/action.yml at that exact ref.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Comment thread robot-repo-automaton/src/fixer.rs
@gitar-bot

gitar-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review ✅ Approved 1 resolved / 1 findings

Removes a stray semicolon in the fixer to resolve a clippy compile error, but the file was corrupted with raw diff text instead of valid Rust.

✅ 1 resolved
Bug: fixer.rs replaced with raw diff text, not valid Rust

📄 robot-repo-automaton/src/fixer.rs:1-14
The committed contents of robot-repo-automaton/src/fixer.rs are a raw unified-diff fragment — literal @@ hunk headers and +/- prefixed lines — instead of Rust source. The previous ~940-line module was deleted and replaced with 14 lines of diff text, so the crate cannot compile and all fixer functionality (including expand_template) is gone. It appears a patch was pasted into the file rather than applied with git apply/patch. Restore the original file and re-apply only the intended one-line change (removing the trailing semicolon after the .replace(...) chain so expand_template returns String).

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@hyperpolymath
hyperpolymath merged commit dd5945b into main Jul 29, 2026
@hyperpolymath
hyperpolymath deleted the fix/remove-trailing-semicolon-fixer branch July 29, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant