Skip to content

rescue: INT-02 / INT-09 / INT-11 — recover stranded feature work from a deleted checkout - #708

Merged
hyperpolymath merged 3 commits into
mainfrom
rescue/int-02-int-09-int-11
Jul 28, 2026
Merged

rescue: INT-02 / INT-09 / INT-11 — recover stranded feature work from a deleted checkout#708
hyperpolymath merged 3 commits into
mainfrom
rescue/int-02-int-09-int-11

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

These three commits existed only in a local checkout that an estate reorg
renamed to affinescript.DUPLICATE-superseded-2026-07-27 and then deleted.
They were never on origin. Recovered from a git bundle taken before the
deletion.

The "superseded" label was wrong — see
dev-notes/affinescript-sitrep-2026-07-27.md. The rename judged duplicates by
directory identity rather than by git rev-list, so a checkout holding 9
unpushed commits was marked redundant against one holding 0.

What

Exactly the three hand-authored feature commits, at their original SHAs,
authorship and dates
:

No cherry-pick was required: the three form a contiguous linear chain whose base
commit's parent is origin/main (1c169c0), so the branch was created at
e959636.

8 files, +258/−22 — affinescript-cadre/ (router runtime + e2e),
affinescript-dom/e2e/ (browser parity harness), docs/ECOSYSTEM.adoc.

Deliberately excluded

The other 6 commits in that stack were sweep-authored, including a merge of an
unexplained "rogue duplicate repository" and an uncommitted change that
deletes *.affine text eol=lf linguist-language=AffineScript from
.gitattributes — the line making GitHub recognise 493 source files as
AffineScript. They remain parked in the bundle, unreviewed.

Checks

  • No sweep debris: .gitattributes, .gitignore, docs/patch_ecosystem.py all absent from the diff
  • Licences: 5 × MPL-2.0, no stray AGPL
  • Secrets: none
  • REUSE: the two headerless files match existing repo convention (no .reuse//REUSE.toml; none of the 5 existing package.json carry headers)

Draft — CI has not run on these commits before.

🤖 Generated with Claude Code

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Comment thread affinescript-dom/e2e/dom_host.mjs
@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review ✅ Approved 1 resolved / 1 findings

Recovers stranded feature work adding router navigation, browser host parity, and docs resolution, but nesting wasi_snapshot_preview1 under env breaks WASM linking.

✅ 1 resolved
Bug: wasi_snapshot_preview1 nested under env, breaking WASM link

📄 affinescript-dom/e2e/dom_host.mjs:50-54
buildImportObject(env, { imports: { wasi_snapshot_preview1: { fd_write } } }) merges options.imports into the env namespace, so wasi_snapshot_preview1.fd_write becomes importObject.env.wasi_snapshot_preview1 instead of a top-level wasi_snapshot_preview1 namespace. The WASM module imports fd_write from module wasi_snapshot_preview1, so WebAssembly.instantiate throws a LinkError and the reconciler never runs — defeating the INT-11 harness this PR adds. Use the modules option (which loader.js adds verbatim as separate namespaces) instead of imports.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@hyperpolymath
hyperpolymath marked this pull request as ready for review July 28, 2026 18:20
@hyperpolymath
hyperpolymath merged commit 9a27760 into main Jul 28, 2026
19 of 20 checks passed
@hyperpolymath
hyperpolymath deleted the rescue/int-02-int-09-int-11 branch July 28, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

INT-02 follow-up: affinescript-dom-loader satellite shell — scope question (split repo vs fold-into affine-js)

1 participant