fix(ws): keep spot asset ctx fields and map identifier - #197
Open
DorianHsia wants to merge 1 commit into
Open
Conversation
activeSpotAssetCtx payloads include totalSupply and dayBaseVlm which were dropped, and there was no test that spot ctx still routes to the ActiveAssetCtx subscription key. Persist those optional fields and add deserialize plus identifier regression tests. Fixes hyperliquid-dex#88. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Subscribing with
ActiveAssetCtxfor a spot coin (@107) returns channelactiveSpotAssetCtx. The livectxalso includestotalSupplyanddayBaseVlm, whichSpotAssetCtxdropped.Closes #88.
Change
total_supplyandday_base_vlmonSpotAssetCtx(serde(default)).Message::ActiveSpotAssetCtx, extra fields round-trip, andget_identifierequalsSubscription::ActiveAssetCtx { coin }. PerpsactiveAssetCtxstill maps the same way.cargo test --lib -- ws::Made with Cursor