Updates for Hyperlight 0.13 release by jsturtevant · Pull Request #389 · hyperlight-dev/hyperlight-wasm

jsturtevant · 2026-02-24T22:30:58Z

Instead of using a shared memory region or a host function callback
to provide host function definitions to the guest, the host now pushes
the serialized definitions directly as a parameter to InitWasmRuntime.

fixes #388

ludfjig

I think this looks good

src/wasm_runtime/src/module.rs

Copilot

Pull request overview

This PR removes the guest’s dependency on a dedicated “host function definition region” by having the host serialize host function definitions and pass them directly into the guest’s InitWasmRuntime call, aligning with upstream HL-core changes (issue #388).

Changes:

Update the guest wasm runtime to parse HostFunctionDetails from InitWasmRuntime parameters (VecBytes) instead of reading from a shared region / callback.
Update the host sandbox initialization to track + serialize registered host function definitions and pass them into InitWasmRuntime.
Remove SandboxBuilder::with_function_definition_size and document the breaking change; add [workspace] stanzas to excluded crates to avoid workspace resolution issues.

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/wasm_runtime/src/module.rs	`InitWasmRuntime` now expects a VecBytes parameter containing serialized host function details and registers host funcs from it.
src/wasm_runtime/src/hostfuncs.rs	Removes the old `get_host_function_details()` path.
src/wasm_runtime/src/component.rs	Updates `InitWasmRuntime` signature in the component runtime interface (now takes VecBytes).
src/hyperlight_wasm/src/sandbox/proto_wasm_sandbox.rs	Tracks host function definitions as they’re registered; serializes and passes them to `InitWasmRuntime`.
src/hyperlight_wasm/src/sandbox/sandbox_builder.rs	Removes the builder API for host function definition region sizing.
src/hyperlight_wasm/src/sandbox/loaded_wasm_sandbox.rs	Adds a regression test ensuring missing host functions fail module load.
src/hyperlight_wasm/Cargo.toml	Adds `hyperlight-common` dependency used for flatbuffer wrapper types.
Cargo.toml	Adds `hyperlight-common` to workspace dependencies.
Cargo.lock	Locks `hyperlight-common` dependency.
src/rust_wasm_samples/Cargo.toml	Adds `[workspace]` to make the crate a standalone workspace root when built directly.
src/hyperlight_wasm_macro/Cargo.toml	Adds `[workspace]` to make the crate a standalone workspace root when built directly.
src/component_sample/Cargo.toml	Adds `[workspace]` to make the crate a standalone workspace root when built directly.
CHANGELOG.md	Documents the breaking removal of `SandboxBuilder::with_function_definition_size`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/hyperlight_wasm/src/sandbox/proto_wasm_sandbox.rs

src/wasm_runtime/src/module.rs

dblnz

LGTM!
I left some small comments that are not necessary to be addressed in this PR.

src/component_sample/Cargo.toml

src/hyperlight_wasm_macro/Cargo.toml

src/wasm_runtime/src/module.rs

syntactically

Mostly LGTM, except for the comment about HostPrint.

syntactically · 2026-03-05T13:24:57Z

src/hyperlight_wasm/src/sandbox/proto_wasm_sandbox.rs

-        Ok(Self { inner: Some(inner) })
+
+        // HostPrint is always registered by UninitializedSandbox, so include it by default
+        let host_function_definitions = vec![HostFunctionDefinition {


I'm not convinced this should be here. HostPrint is sort of an internal implementation detail? I don't think that wasm modules should be able to just import it automatically with no way to remove that.

I wasn't sure of an alternative. We have to have it or the linker won't work. I believe this was already happening before now its just explicit. Do you have any suggestions?

We have to have it or the linker won't work.

I'm not sure I follow? I don't think we have any wasm module code that calls HostPrint directly?

I know we use HostPrint in the wasip1 stub for fd_write, but that's just doing an explicit call_host_function call--it doesn't need to look it up in the hostfunctiondefinitions, as far as I can tell?

The components currently expect this to be there:

hyperlight-wasm/src/wasmsamples/RunWasm.c

Line 25 in 9cbfe7a

int HostPrint(char* msg); // Implementation of this will be available in the native host

I've pushed a change to move it to the runtime initialization. The other option would be to make the Host print a function modules register explicitly?

src/hyperlight_wasm/src/sandbox/proto_wasm_sandbox.rs

src/hyperlight_wasm_macro/Cargo.toml

dblnz · 2026-03-06T14:53:56Z

Have you tried compiling this with the latest hyperlight main? I'm having some issues locally when I'm trying to build

Instead of using a shared memory region or a host function callback to provide host function definitions to the guest, the host now pushes the serialized definitions directly as a parameter to InitWasmRuntime. Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

rust_wasm_samples, hyperlight_wasm_macro, and component_sample were missing empty [workspace] tables in their Cargo.toml files. Without this, Cargo resolves to the main checkout's workspace root when run from a git worktree, causing 'believes it's in a workspace' errors. wasm_runtime already had this marker. Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

jsturtevant · 2026-03-07T00:47:02Z

src/hyperlight_wasm/src/sandbox/wasm_sandbox.rs

-        } else {
-            let wasm_bytes = unsafe { std::slice::from_raw_parts(base as *const u8, len).to_vec() };
-            load_wasm_module_from_bytes(inner, wasm_bytes)?;
-        }


This isn't great, but we made map_region private in hyperlight-dev/hyperlight@ffa7d8d#diff-ff2b13b76470ee68e295ce3277b29d2557ac2f403f696f5eec5adb12af3c27f6

We will need a patch release to use here

jsturtevant added the kind/bugfix label Feb 24, 2026

ludfjig previously approved these changes Feb 24, 2026

View reviewed changes

src/wasm_runtime/src/module.rs Show resolved Hide resolved

ludfjig requested a review from Copilot February 24, 2026 22:44

Copilot started reviewing on behalf of ludfjig February 24, 2026 22:44 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

src/hyperlight_wasm/src/sandbox/proto_wasm_sandbox.rs Outdated Show resolved Hide resolved

src/hyperlight_wasm/src/sandbox/proto_wasm_sandbox.rs Outdated Show resolved Hide resolved

src/wasm_runtime/src/module.rs Outdated Show resolved Hide resolved

jsturtevant mentioned this pull request Mar 3, 2026

use the #[guest_func] macro on init_wasm_runtime instead of manually calling register_function? #395

Open

jsturtevant dismissed ludfjig’s stale review via c5b5956 March 3, 2026 01:59

dblnz previously approved these changes Mar 5, 2026

View reviewed changes

src/component_sample/Cargo.toml Show resolved Hide resolved

src/hyperlight_wasm_macro/Cargo.toml Show resolved Hide resolved

src/wasm_runtime/src/module.rs Outdated Show resolved Hide resolved

syntactically reviewed Mar 5, 2026

View reviewed changes

jsturtevant added 4 commits March 6, 2026 14:07

Address feedback

2610e46

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

Upgrade to Hyperlight 0.13

fdc9d14

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

jsturtevant dismissed dblnz’s stale review via fdc9d14 March 6, 2026 22:08

jsturtevant force-pushed the rally/388-remove-host-function-definition-region branch from c5b5956 to fdc9d14 Compare March 6, 2026 22:08

jsturtevant changed the title ~~Remove host function definition region dependency~~ Updates for Hyperlight 0.13 release Mar 6, 2026

Move the HostPrint Registration

6cba4bd

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>

This was referenced Mar 6, 2026

feat: add world selection for multi-world WIT files #394

Open

Consider moving the hostfunctions definitions from Hyperlight common hyperlight-dev/hyperlight#1286

Open

jsturtevant commented Mar 7, 2026

View reviewed changes

Conversation

jsturtevant commented Feb 24, 2026

Uh oh!

ludfjig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dblnz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

syntactically left a comment

Choose a reason for hiding this comment

Uh oh!

syntactically Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

jsturtevant Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

syntactically Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

jsturtevant Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dblnz commented Mar 6, 2026

Uh oh!

jsturtevant Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants