Protect operations database from non-string data in error messages fr…#1716
Open
davecrighton wants to merge 2 commits intohyperledger:mainfrom
Open
Protect operations database from non-string data in error messages fr…#1716davecrighton wants to merge 2 commits intohyperledger:mainfrom
davecrighton wants to merge 2 commits intohyperledger:mainfrom
Conversation
…om reverts Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1716 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 342 342
Lines 25022 25027 +5
=======================================
+ Hits 25014 25019 +5
Misses 4 4
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Dave Crighton <dave.crighton@kaleido.io>
davecrighton
force-pushed
the
djc/protectDBAccess
branch
from
765a1c5 to
fe2e153
Compare
peterbroadhurst
requested changes
Mar 4, 2026
| update = update.Set("error", hexString) | ||
| } else { | ||
| update = update.Set("error", *errorMsg) | ||
| } |
Contributor
There was a problem hiding this comment.
Can you make this a utility function please, in a place that can be used across packages.
Then this line becomes:
Suggested change
| } | |
| update = update.Set("error", utils.DBSafeStringFromPtr(errorMsg)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change tests the error string before making an update to the operations table checking that it is a valid UTF-8 string and does not contain null bytes. The second check is required because UTF-8 considers a single null byte to be a valid string but Postgres does not.
Fixes #1717
Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.