This repository was archived by the owner on Apr 13, 2022. It is now read-only.
fix: preserve context with cls-hooked#142
Open
diestrin wants to merge 1 commit intohyperledger-labs:developfrom
Open
fix: preserve context with cls-hooked#142diestrin wants to merge 1 commit intohyperledger-labs:developfrom
diestrin wants to merge 1 commit intohyperledger-labs:developfrom
Conversation
dbda42d to
e1ef464
Compare
Signed-off-by: Diego Barahona <diestrin@gmail.com>
e1ef464 to
8f012a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use a context data library, cls-hooked to fix a context issue reported in #105.
Previously, convector had problems with concurrent transaction, because it was setting a global variable BaseStorage.current on each chaincode
@Invoke. This variable contains a reference to the Fabric STUB object, where operations (reads and writes to the ledger) get written for each transaction. So when a second@Invokeis received, the STUB gets overwritten, and all the operations of the first transaction still pending to run (because asynchronicity) end up being registered in the incorrect STUB. This causes all sorts of wrong behaviors, like trying to write in a transaction STUB that has already finished, or simply putting the reads and writes in different blocks, which is not accurate at all.Types of changes
Checklist