fix(proxy): parse per-scheme Windows ProxyServer format - #318
Open
atheerium wants to merge 1 commit into
Open
Conversation
Windows WinINET registry ProxyServer values can be in per-scheme format (e.g. "http=127.0.0.1:8080;https=127.0.0.1:8443;socks=127.0.0.1:1080") rather than a single bare proxy address. Previously the raw value was assigned verbatim to both http and https proxy fields, which broke socks= and scheme-specific entries. Now we parse the value into per-scheme assignments. A socks= entry maps to the all-schemes proxy bucket, matching WinINET semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...