fix(client): parse CONNECT responses and preserve early data - #313
Closed
hunterinvariants wants to merge 1 commit into
Closed
fix(client): parse CONNECT responses and preserve early data#313hunterinvariants wants to merge 1 commit into
hunterinvariants wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP CONNECT helper previously recognized responses using byte-prefix checks and required the header terminator to occur at the end of a read buffer. This could accept malformed status lines and mishandle data received immediately after a successful CONNECT response.
This change:
httparse;TunnelConnection<C::Response>that replays bytes read beyond the response headers;Tunnel<C>now usesTunnelConnection<C::Response>as itsService::Response, since retaining bytes already read from the destination requires a buffered return type.Verified with the complete all-features test suite.
Fixes hyperium/hyper#4095