fix: keep toStartOf* time filters inclusive regardless of dateRangeEndInclusive#1915
Open
sanjams2 wants to merge 1 commit intohyperdxio:mainfrom
Open
fix: keep toStartOf* time filters inclusive regardless of dateRangeEndInclusive#1915sanjams2 wants to merge 1 commit intohyperdxio:mainfrom
sanjams2 wants to merge 1 commit intohyperdxio:mainfrom
Conversation
…dInclusive == Motivation == Time histograms on the search page silently drop data past an hour/minute boundary when the source `timestampValueExpression` includes a `toStartOf*` expression for primary key optimization. == Details == When `convertToTimeChartConfig` aligns the date range to granularity it sets `dateRangeEndInclusive: false`, which is correct for the raw timestamp column (end was rounded up, so `<` gives equivalent coverage). But `timeFilterExpr` applies that same `<` uniformly to every expression in a compound `timestampValueExpression`. With a range ending at `04:08`, this yields `toStartOfHour(ts) < toStartOfHour(04:08)` = `< 04:00` — excluding the entire `04:xx` hour. The coarse filter exists only for index pruning; the raw column already enforces exact bounds. Making it wider by one interval is harmless, making it narrower drops real rows. == Testing == - `yarn jest renderChartConfig.test.ts` — 54 passed, 29 snapshots passed - Added cases for `toStartOfHour` with exclusive end, compound expr with exclusive end, and exclusive start
🦋 Changeset detectedLatest commit: 3349461 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@sanjams2 is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
PR Review✅ No critical issues found. The fix is correct and well-reasoned:
One minor observation: there's no test for a compound expression with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
== Motivation ==
Time histograms on the search page silently drop data past an hour/minute boundary when the source
timestampValueExpressionincludes atoStartOf*expression for primary key optimization.== Details ==
When
convertToTimeChartConfigaligns the date range to granularity it setsdateRangeEndInclusive: false, which is correct for the raw timestamp column (end was rounded up, so<gives equivalent coverage). ButtimeFilterExprapplies that same<uniformly to every expression in a compoundtimestampValueExpression. With a range ending at04:08, this yieldstoStartOfHour(ts) < toStartOfHour(04:08)=< 04:00— excluding the entire04:xxhour.The coarse filter exists only for index pruning; the raw column already enforces exact bounds. Making it wider by one interval is harmless, making it narrower drops real rows.
== Testing ==
yarn jest renderChartConfig.test.ts— 54 passed, 29 snapshots passedtoStartOfHourwith exclusive end, compound expr with exclusive end, and exclusive start