feat: show inline span durations in trace timeline#1886
feat: show inline span durations in trace timeline#1886karl-power wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2290d75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR Review
|
E2E Test Results✅ All tests passed • 88 passed • 3 skipped • 903s
Tests ran across 4 shards in parallel. |
98f711e to
e44215d
Compare
e44215d to
2290d75
Compare
Summary
Adds duration labels next to each span bar in the trace waterfall timeline so users can read the duration at a glance without hovering the tooltip.
Changes
Timeline chart
12ms,1.2s) outside each bar usingposition: absolute, so it doesn’t affect layout.maxVal / 2), to keep it in the emptier side.renderMs()fromTimelineChart/utilsfor formatting.overflow: visibleso the duration label is not clipped by the bar’stext-truncate(overflow hidden).showDuration?: boolean. Whenfalse, the duration label is hidden (default is to show).DBTraceWaterfallChart
showDuration: type !== SourceKind.Logso log rows do not show a duration (only spans do).Screenshots
Testing
References