Skip to content

Improve Search Result Side Panel to fix various bugs#1587

Merged
kodiakhq[bot] merged 3 commits intomainfrom
brandon/drawer-bugfixes
Jan 12, 2026
Merged

Improve Search Result Side Panel to fix various bugs#1587
kodiakhq[bot] merged 3 commits intomainfrom
brandon/drawer-bugfixes

Conversation

@brandon-pereira
Copy link
Copy Markdown
Member

@brandon-pereira brandon-pereira commented Jan 10, 2026

  1. Ensures that multiple scrollbars are not shown for nested panels (click row -> surrounding context -> repeat a few times)
scrollbars
  1. In the same state as above, closing the panel (clicking outside) then clicking another row caused the subpanel to re-open, this isn't ideal (should open to root drawer)
  2. fix issue with drawers where you can scroll, then open a nested drawer, the nested drawer would appear incorrectly
Screenshot 2026-01-09 at 5 10 29 PM

Fixes HDX-3171

@brandon-pereira
Improve Search Result Side Panel to fix various bugs
7457c52 
1. Ensures that multiple scrollbars are not shown for nested panels (click row -> surrounding context -> repeat a few times)
2. In the same state as above, closing the panel (clicking outside) then clicking another row caused the subpanel to re-open, this isn't ideal (should open to root drawer)
3. fix issue with drawers where you can scroll, then open a nested drawer, the nested drawer would appear incorrectly

Fixes HDX-3171
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 4fadb07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Jan 12, 2026 6:09pm

brandon-pereira
brandon-pereira commented Jan 10, 2026
View reviewed changes
Comment thread packages/app/src/components/DBRowSidePanel.tsx
<Drawer
opened={rowId != null}
withCloseButton={false}
withinPortal={!isNestedPanel}
Copy link
Copy Markdown
Member Author

@brandon-pereira brandon-pereira Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally added in #1290 when we didn't sue mantine drawer, not needed anymore.

brandon-pereira
brandon-pereira commented Jan 10, 2026
View reviewed changes
Comment thread packages/app/src/components/DBRowSidePanel.tsx
opened={rowId != null}
withCloseButton={false}
withinPortal={!isNestedPanel}
withOverlay={!isNestedPanel}
Copy link
Copy Markdown
Member Author

@brandon-pereira brandon-pereira Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps prevent some issues flagged originally in #1393, ensuring clicking outside closes all modals and that there isn't multiple stacking overlays (causing outside to get darker each sub-modal)

@claude
Copy link
Copy Markdown

claude Bot commented Jan 10, 2026 •
edited
Loading

Code Review

✅ No critical issues found.

The changes look good overall. The PR addresses nested drawer scrollbar issues and state management correctly:

  1. State management fix - useNestedPanelState() called without parameter correctly defaults to URL-based state for root panels
  2. Overlay fix - withOverlay={!isNestedPanel} correctly shows backdrop only on root panels
  3. Cleanup logic - Properly clears nested panel state when closing root drawer

Minor consideration:
The change from withinPortal to withOverlay on DBRowSidePanel.tsx:562 - these are different Mantine props. Verify the drawer still renders correctly (especially z-index and positioning with nested modals/dropdowns). If portal rendering is needed, you may need to keep withinPortal alongside withOverlay.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 10, 2026 •
edited
Loading

E2E Test Results

❌ 52 tests failed • 9 passed • 3 skipped • 1717s

Status Count
✅ Passed 9
❌ Failed 52
⚠️ Flaky 0
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@brandon-pereira brandon-pereira requested review from a team, bot-hyperdx and dhable and removed request for a team and bot-hyperdx January 12, 2026 16:03
@kodiakhq kodiakhq Bot merged commit ddc7dd0 into main Jan 12, 2026
8 of 12 checks passed
@kodiakhq kodiakhq Bot deleted the brandon/drawer-bugfixes branch January 12, 2026 18:09
knudtty pushed a commit that referenced this pull request Apr 16, 2026
@brandon-pereira
Improve Search Result Side Panel to fix various bugs (#1587)
3d1c724 
1. Ensures that multiple scrollbars are not shown for nested panels (click row -> surrounding context -> repeat a few times)
<img width="1402" height="876" alt="scrollbars" src="https://github.com/user-attachments/assets/f41c99e5-5fcb-47fa-9c40-243dbd926291" />


2. In the same state as above, closing the panel (clicking outside) then clicking another row caused the subpanel to re-open, this isn't ideal (should open to root drawer)
3. fix issue with drawers where you can scroll, then open a nested drawer, the nested drawer would appear incorrectly
<img width="910" height="878" alt="Screenshot 2026-01-09 at 5 10 29 PM" src="https://github.com/user-attachments/assets/fd1fbc0c-4453-46fb-b310-2323ec2792e2" />




Fixes HDX-3171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhable dhable dhable approved these changes

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brandon-pereira @dhable