fix: validate PDS_INTERNAL_URL has http(s) scheme before use#23
fix: validate PDS_INTERNAL_URL has http(s) scheme before use#23
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All 6 call sites reading PDS_INTERNAL_URL now go through ensurePdsUrl(), which fails fast with a clear error when the URL is missing its scheme. Previously a bare hostname (e.g. 'host.railway.internal') silently produced an invalid URL that only surfaced as a cryptic 'TypeError: Failed to parse URL' inside fetch().
636d2a1 to
61db980
Compare
Pull Request Test Coverage Report for Build 23094976254Details
💛 - Coveralls |
Summary
ensurePdsUrl()helper that validates the URL includes anhttp://orhttps://scheme, failing fast with a clear error message instead of a crypticTypeError: Failed to parse URLdeep insidefetch()PDS_INTERNAL_URLin auth-service to use the new helperContext
In Railway prod,
PDS_INTERNAL_URLwas set to a bare hostname without a scheme (certified-apppds-core.railway.internal), causing:With this fix the service will instead throw at startup (or first use for lazy call sites):