Skip to content

Revert "367 aggregation" #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjlippold merged 1 commit into from
Mar 3, 2026
Merged

Revert "367 aggregation" #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
291 changes: 0 additions & 291 deletions domains/etl/aggregation.py
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions domains/etl/migrations/0004_task_task_type_and_nullable_data_connection.py
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions domains/etl/models/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,10 @@ def visible(self, principal: Union["User", "APIKey"]):
class Task(models.Model, PermissionChecker):
id = models.UUIDField(primary_key=True, default=uuid6.uuid7, editable=False)
name = models.CharField(max_length=255)
task_type = models.CharField(max_length=32, default="ETL")
workspace = models.ForeignKey(
"iam.Workspace", related_name="tasks", on_delete=models.CASCADE
)
data_connection = models.ForeignKey(
DataConnection,
on_delete=models.CASCADE,
related_name="tasks",
null=True,
blank=True,
)
data_connection = models.ForeignKey(DataConnection, on_delete=models.CASCADE, related_name="tasks")
orchestration_system = models.ForeignKey(
OrchestrationSystem, on_delete=models.CASCADE, related_name="tasks"
)
Expand Down Expand Up @@ -99,7 +92,7 @@ def get_principal_permissions(
self, principal: Union["User", "APIKey", None]
) -> list[Literal["edit", "delete", "view"]]:
permissions = self.check_object_permissions(
principal=principal, workspace=self.workspace, resource_type="Task"
principal=principal, workspace=self.data_connection.workspace, resource_type="Task"
)

return permissions
Expand Down
Loading