Fix: rename a2a3 scope_stats_collector test target to avoid name clash#1080
Conversation
The host-side test_scope_stats_collector target (common/) and the a2a3 runtime variant shared the same logical target name, violating CMake CMP0002 and failing configure with exit 1. Prefix the a2a3 variant per the existing convention (see test_a2a3_tensormap and the a5_ prefix note) so both targets coexist.
There was a problem hiding this comment.
Code Review
This pull request updates the CMake configuration in tests/ut/cpp/CMakeLists.txt to rename the runtime test target test_scope_stats_collector to test_a2a3_scope_stats_collector. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesRename a2a3 Scope Stats Test Target
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
tests/ut/cpp/CMakeLists.txtdefined the logical target nametest_scope_stats_collectortwice: once viaadd_executablefor thehost-side test (
common/test_scope_stats_collector.cpp, line 319) andonce via
add_a2a3_runtime_testfor the a2a3 runtime variant(
a2a3/test_scope_stats_collector.cpp, line 377). The macro internallycalls
add_executable(${name} ...), so the duplicate logical targetviolated CMake CMP0002 and failed configure with exit 1 (no build /
device involvement).
test_a2a3_scope_stats_collector, followingthe existing convention in this file (
test_a2a3_tensormap, and thea5_prefix note on the A5 block) so both tests coexist as distincttargets.
Testing
cmakeconfigure now succeeds (CMP0002 clash resolved)test_scope_stats_collector(host)and
test_a2a3_scope_stats_collector(a2a3 runtime)