Skip to content

[PTODSL] Add low precision conversion surface#822

Draft
jimmychou0 wants to merge 1 commit into
hw-native-sys:mainfrom
jimmychou0:ptodsl-low-precision-surface
Draft

[PTODSL] Add low precision conversion surface#822
jimmychou0 wants to merge 1 commit into
hw-native-sys:mainfrom
jimmychou0:ptodsl-low-precision-surface

Conversation

@jimmychou0

@jimmychou0 jimmychou0 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allow PTODSL low-precision dtypes in pto.ptr(...) and pto.vreg_type(...)
  • add low-precision pto.vcvt surface coverage and frontend-side attr validation aligned with VPTO contracts
  • update PTODSL user guide and tests for low-precision vector memory and conversion flows

Validation

  • ptodsl/tests/test_jit_compile.py
  • ptodsl/tests/test_docs_as_test.py
  • ptodsl/tests/test_ptoas_frontend_verify.py
  • git diff --check

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@reedhecre

reedhecre commented Jun 16, 2026

Copy link
Copy Markdown

Codex Review

该评论由 review 机器人自动更新。

  • PR: [PTODSL] Add low precision conversion surface #822 [PTODSL] Add low precision conversion surface
  • Author: jimmychou0
  • Base/Head: main / ptodsl-low-precision-surface
  • Head SHA: 9ab4f243b836
  • Trigger: 检测到新的 open PR
  • Generated At: 2026-06-16T03:56:07Z
  • Status: failed at codex-review (exit=1)

Summary

Review failed at stage codex-review: exit=1

Findings

未生成结构化 findings,因为 review 过程提前失败。

Log Tail

git checkout -f 'pr-822'
git rev-parse HEAD
git diff --stat 'origin/main...HEAD' || true
Cloning into '/tmp/ptoas-pr-review-monitor/runs/20260616_115527_pr822/repo'...
From https://github.com/hw-native-sys/PTOAS
 * [new ref]         refs/pull/822/head -> pr-822
 * [new tag]         v0.36              -> v0.36
From https://github.com/hw-native-sys/PTOAS
 * branch            main       -> FETCH_HEAD
Switched to branch 'pr-822'
9ab4f243b836728adb7acce8737d85fe0b95bb6a
 .../docs/user_guide/04-type-system-and-buffer.md   |  10 +-
 ptodsl/docs/user_guide/07-data-movement-ops.md     |  11 +
 ptodsl/docs/user_guide/08-compute-operations.md    |  32 ++-
 ptodsl/ptodsl/_ops.py                              | 244 +++++++++++++++++----
 ptodsl/ptodsl/_surface_types.py                    |   3 +
 ptodsl/ptodsl/_types.py                            |   4 +-
 ptodsl/ptodsl/pto.py                               |   1 +
 ptodsl/tests/support/docs_fragment_fixtures.py     |  20 ++
 ptodsl/tests/test_jit_compile.py                   | 115 +++++++++-
 ptodsl/tests/test_ptoas_frontend_verify.py         |  35 +++
 10 files changed, 415 insertions(+), 60 deletions(-)
===== END STAGE clone rc=0 @ 2026-06-16 11:55:33 =====

===== STAGE codex-review @ 2026-06-16 11:55:33 =====
set -euo pipefail
cd '/tmp/ptoas-pr-review-monitor/runs/20260616_115527_pr822/repo'
'codex' exec -C '/tmp/ptoas-pr-review-monitor/runs/20260616_115527_pr822/repo' -s read-only -c 'model_provider="codereview"' -c 'model="gpt-5.4"' -c 'model_reasoning_effort="xhigh"' --output-schema '/tmp/ptoas-pr-review-monitor/runs/20260616_115527_pr822/review_schema.json' -o '/tmp/ptoas-pr-review-monitor/runs/20260616_115527_pr822/codex_last_message.json' --color never - < '/tmp/ptoas-pr-review-monitor/runs/20260616_115527_pr822/review_prompt.txt'
OpenAI Codex v0.115.0 (research preview)
--------
workdir: /tmp/ptoas-pr-review-monitor/runs/20260616_115527_pr822/repo
model: gpt-5.4
provider: codereview
approval: never
sandbox: read-only
reasoning effort: xhigh
reasoning summaries: none
session id: 019ece91-f9b7-70f1-acd5-b05cfa0b5541
--------
user
你现在在审查 GitHub PR。

仓库:hw-native-sys/PTOAS
PR:#822 [PTODSL] Add low precision conversion surface
作者:jimmychou0
base branch:origin/main
head branch:HEAD(当前已 checkout 到 PR head)

要求:
1. 只审查这个 PR 相对 origin/main 的改动,必要时可以看上下文文件。
2. 重点找真实的 correctness / regression / contract mismatch / CI / runtime / compatibility 问题。
3. 不要提纯风格建议,不要提低价值猜测。
4. 严格按优先级输出:
   - P1:高概率会导致错误结果、编译/运行失败、严重回归、发布阻断
   - P2:重要缺陷、行为回归、遗漏校验/测试、较大兼容性问题
   - P3:次要但明确可改的问题
5. 如果没有问题,summary 直接写:未检查到 PR #822 存在问题,并返回 findings=[]。
6. 如果有问题,summary 简洁概括,findings 里每条都要给出:
   - severity
   - title
   - body(说明为什么是问题,尽量具体)
   - file(尽量给相对路径)
   - line(能确定就填整数,否则 null)

建议先查看:
- git status --short
- git diff --stat origin/main...HEAD
- git diff --unified=80 origin/main...HEAD

最终输出必须严格匹配 JSON schema。

mcp startup: no servers
Reconnecting... 1/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: bdf71a9d-6f48-4bbe-852c-d1c68727ea81)
Reconnecting... 2/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: bf38c95c-f184-4eb1-bf49-c260d5cc1a6e)
Reconnecting... 3/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: 7b21c76c-7245-4930-96a5-b19eb02eb2a7)
Reconnecting... 4/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: e4bf7f83-eb93-44d0-8a1e-d7b1300b77c7)
Reconnecting... 5/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: 4550f058-5584-4350-bac2-b2e3b8d7c1d3)
ERROR: unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: 1fb494de-909c-4e67-9d26-e66743a53e1d
Warning: no last agent message; wrote empty content to /tmp/ptoas-pr-review-monitor/runs/20260616_115527_pr822/codex_last_message.json
===== END STAGE codex-review rc=1 @ 2026-06-16 11:56:07 =====

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants