Fix Docker workspace build order by excluding app workspace from early foreach step#3798
Open
Fix Docker workspace build order by excluding app workspace from early foreach step#3798
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
None
Context behind the change
Several app Dockerfiles were building workspaces too early with:
yarn workspaces foreach -Rpt --from <app> run buildAt that stage, the full app source was not copied yet, so the app workspace could fail (for example missing
tsconfig.json).This PR updates those Dockerfiles to build only dependency workspaces first
--exclude <app>, and keeps app build in the final RUN yarn build step after full source copy.How has this been tested?
Ran full local path:
DOCKER_PARALLEL=1 make -C docker-setup build-services.Release plan
None
Potential risks; What to monitor; Rollback plan
None