Open
Conversation
…update exception filters to handle subgraph errors
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
dnechay
reviewed
Feb 12, 2026
Collaborator
dnechay
left a comment
dnechay
left a comment
There was a problem hiding this comment.
LGTM overall, one suggestion
Also please add to release plan that we need to add new monitor+alert on DataDog based on new logs
Comment on lines
34
to
44
| if (exception instanceof SubgraphBadIndexerError) { | ||
| this.logger.warn('Subgraph bad indexers', { | ||
| error: exception, | ||
| path: request.url, | ||
| }); | ||
| } else { | ||
| this.logger.error('Subgraph request failed', { | ||
| error: exception, | ||
| path: request.url, | ||
| }); | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (exception instanceof SubgraphBadIndexerError) { | |
| this.logger.warn('Subgraph bad indexers', { | |
| error: exception, | |
| path: request.url, | |
| }); | |
| } else { | |
| this.logger.error('Subgraph request failed', { | |
| error: exception, | |
| path: request.url, | |
| }); | |
| } | |
| this.logger.error('Unhandled subgraph error', { | |
| error: exception, | |
| path: request.url, | |
| }); |
If it's necessary - in DataDog it will be possible to filter errors based on the error.name (aka exception.name) so we will be able to distinguish between them and set up different alerts if needed
vercel
bot
temporarily deployed
to
Preview – human-dashboard-frontend
dnechay
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
Close #3745
Context behind the change
SubgraphRequestError,SubgraphBadIndexerError)How has this been tested?
Ran unit tests
Release plan
Potential risks; What to monitor; Rollback plan
None