Remove unused shared_expert_combination_strategy from cohere2_moe#46408
Open
ArthurZucker wants to merge 1 commit into
Open
Remove unused shared_expert_combination_strategy from cohere2_moe#46408ArthurZucker wants to merge 1 commit into
ArthurZucker wants to merge 1 commit into
Conversation
All published cohere2_moe checkpoints (the command-a-plus-05-2026 family) use the 'average' strategy; the 'sum' branch is dead. Drop the config field and always average the shared-expert output. Existing configs that still carry the key load unchanged (it is ignored).
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: cohere2_moe |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
Jun 4, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Fair enough, if worst comes to worst we can readd this but I would only expect that on future models with only that change (unlikely)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sumbranch ofshared_expert_combination_strategyis dead: every publishedcohere2_moecheckpoint (thecommand-a-plus-05-2026family + its derivatives) usesaverage. Drop the config field and always average the shared-expert output.Existing configs that still carry the key load unchanged (it's ignored). Tests:
tests/models/cohere2_moepass (TP tests need multi-GPU). AI-assisted, human-reviewed.