fix[vLLM x v5]: Default untied embeddings in AudioFlamingo3 and VibeVoice#46400
Merged
vasqu merged 1 commit intoJun 4, 2026
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: audioflamingo3, vibevoice_asr |
7 tasks
ebezzam
reviewed
Jun 4, 2026
eustlb
approved these changes
Jun 4, 2026
Contributor
eustlb
left a comment
There was a problem hiding this comment.
Yep, it slipped through... Thanks a lot for catching @harshaljanjani ! Agree that simply removing the field is better here
Contributor
|
CI Dashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
→ Fixes vllm-project/vllm#39330 (comment)
→ Corrects the
tie_word_embeddingsdefault for AudioFlamingo3 and VibeVoice for integration with the vLLM Transformers backend. This only causes issues with vLLM and not Transformers because Transformers always loads checkpoint weights regardless oftie_word_embeddings(or in other words, it's a hint for init-time tying, not a directive as in vLLM to my understanding).→ Made sure this doesn't cause any regressions in
tests/models/audioflamingo3/andtests/models/vibevoice_asr/Model-wise behavior
→ AudioFlamingo3 and VibeVoice: These models break under the current default; their checkpoints contain distinct
lm_headandembed_tokensweights (with a max difference of ~1.0 to 1.7). Substitution produces garbage outputs.→ GraniteSpeech: Works fine as-is because it genuinely ties its embeddings and has no separate
lm_headin the checkpoint.→ GLM-ASR: Works fine as-is. It has separate
lm_headandembed_tokens, but they are bitwise identical (max diff = 0.0), so tying them produces the same result.cc: @eustlb @vasqu
Code Agent Policy
Before submitting