Skip to content

Raise tqdm minimum to 4.60 to match tqdm.contrib.logging import#46397

Merged
remi-or merged 2 commits into
huggingface:mainfrom
n0gu-furiosa:update-tqdm-dep
Jun 4, 2026
Merged

Raise tqdm minimum to 4.60 to match tqdm.contrib.logging import#46397
remi-or merged 2 commits into
huggingface:mainfrom
n0gu-furiosa:update-tqdm-dep

Conversation

@n0gu-furiosa
Copy link
Copy Markdown
Contributor

@n0gu-furiosa n0gu-furiosa commented Jun 4, 2026

What does this PR do?

transformers/generation/continuous_batching/continuous_api.py imports tqdm.contrib.logging, which was added in tqdm 4.60. The current declared minimum tqdm>=4.27 lets resolvers pick older versions (we hit tqdm 4.49 in our environment when a transitive cap forced it), causing ModuleNotFoundError.

Quick repro:

uv pip install "tqdm==4.59" && python src/transformers/generation/continuous_batching/continuous_api.py
Resolved 1 package in 30ms
Uninstalled 1 package in 12ms
Installed 1 package in 10ms
 - tqdm==4.67.3
 + tqdm==4.59.0
Traceback (most recent call last):
  File "/workspace/huggingface/transformers/src/transformers/generation/continuous_batching/continuous_api.py", line 29, in <module>
    from tqdm.contrib.logging import logging_redirect_tqdm
ModuleNotFoundError: No module named 'tqdm.contrib.logging'

After this PR (ModuleNotFoundError is gone; the remaining ImportError is unrelated noise):

❯ uv pip install "tqdm==4.60" && python src/transformers/generation/continuous_batching/continuous_api.py
Resolved 1 package in 77ms
Prepared 1 package in 22ms
Uninstalled 1 package in 5ms
Installed 1 package in 4ms
 - tqdm==4.59.0
 + tqdm==4.60.0
Traceback (most recent call last):
  File "/workspace/huggingface/transformers/src/transformers/generation/continuous_batching/continuous_api.py", line 31, in <module>
    from ...configuration_utils import PretrainedConfig
ImportError: attempted relative import with no known parent package

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@zucchini-nlp @gante

Signed-off-by: Sungyoon Jeong <sungyoon.jeong@furiosa.ai>
@Rocketknight1
Copy link
Copy Markdown
Member

cc @remi-or @McPatate for continuous batching

Copy link
Copy Markdown
Collaborator

@remi-or remi-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

CI Dashboard: View test results in Grafana

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@remi-or remi-or added this pull request to the merge queue Jun 4, 2026
Merged via the queue into huggingface:main with commit 9c7c911 Jun 4, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants