DIstributed branch base#46269
Open
3outeille wants to merge 4 commits into
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: afmoe, apertus, arcee, aria, audioflamingo3, bamba, bitnet, cohere, cohere2, cohere2_moe, csm, cwm, data2vec, dbrx, deepseek_v2, deepseek_v3 |
Member
|
@3outeille & @ArthurZucker should I port #46126 or thats something already in work and just close it ? |
Member
Author
|
@AmineDiro you can change the base to this branch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current state of things
Dtensor(which we don't want as it is very slow)_sp_planentriesgate_up_proj/grouped_mmkernelsShard-on-readviaDtensorShardOperationmodel.save_pretrained(dir)(no split files checkpoint when distributed) writes a fully-gatheredWhat's missing:
TODO
ep_router + moe_experts_ep_allreduce ParallelStyles(work began by @AmineDiro at EP + Trainer integration on top of DistributedConfig (#45028) #46126)Colwise/Rowwiseto enable inference for continuous batchinghf_bucketsby defaultMoEExpertsParallel("layers.*.mlp.experts.gate_up_proj": "grouped_gemm", "layers.*.mlp.experts.down_proj": "grouped_gemm", "layers.*.mlp.experts": "moe_experts_allreduce",)sparse+densein thesp_planfor models likecohere2_moe,mellum,qwen3_moetp_plan + ep_planfor inference /sp_plan + ep_plantrainingDistributedMixinto isolate (save_pretrained(distributed_checkpoint=True)fromPreTrainedModelPR