Accept stringified primitives in Generable conversions - #185
Open
james-333i wants to merge 1 commit into
Open
Conversation
Some chat templates stringify every tool-call argument value, so models
emit {"count": "5"} where the schema declares an integer. The strict
kind checks in the primitive Generable initializers then throw
typeMismatch, which makes any non-String tool argument unusable on
those backends.
Accept string content in the Bool, Int, Float, Double, and Decimal
initializers when it parses unambiguously as the target type. Native
kinds decode exactly as before, and unparseable strings still throw
typeMismatch. Integer parsing accepts only whole-number values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some chat templates stringify every tool-call argument value, so models emit {"count": "5"} where the schema declares an integer. The strict kind checks in the primitive Generable initializers then throw typeMismatch, which makes any non-String tool argument unusable on those backends.
Accept string content in the Bool, Int, Float, Double, and Decimal initializers when it parses unambiguously as the target type. Native kinds decode exactly as before, and unparseable strings still throw typeMismatch. Integer parsing accepts only whole-number values.