-
Notifications
You must be signed in to change notification settings - Fork 66
CI: run vendored template suites against the SDK checkout #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jaideep/vendor-environment-templates
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,6 +26,33 @@ jobs: | |
| - name: Run tests | ||
| run: uv run --python ${{ matrix.python-version }} --with=".[dev]" pytest --cov --cov-report='' | ||
|
|
||
| templates: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| template: [coding, cua] | ||
|
|
||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install uv | ||
| uses: astral-sh/setup-uv@v5 | ||
|
|
||
| - name: Install template with the SDK from this checkout | ||
| working-directory: environments/${{ matrix.template }} | ||
| run: | | ||
| uv sync --all-extras | ||
| uv pip install -e ../.. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When the checkout removes a dependency previously supplied by the released Useful? React with 👍 / 👎. |
||
|
|
||
| - name: Run template checks | ||
| working-directory: environments/${{ matrix.template }} | ||
| run: | | ||
| uv run --no-sync ruff format . --check | ||
| uv run --no-sync ruff check . | ||
| uv run --no-sync pytest -q | ||
|
|
||
| lint-ruff: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both matrix entries, if a PR changes
environments/<template>/pyproject.tomlwithout updating itsuv.lock, this command silently regenerates the lock in the runner and tests that uncommitted state, allowing CI to pass while the checked-in reproducible environment remains stale.uv sync --helpdocuments--lockedas “Assert that the uv.lock will remain unchanged”; use that option here so dependency and lock changes must be committed together.Useful? React with 👍 / 👎.