Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 523e846
☁️ Nx Cloud last updated this comment at |
🚀 Preview Deploy Report✅ Successfully deployed preview here |
I have no idea why the old @types/uuid was breaking storybook...
…a bad breadcrumb route
Also slightly reduce the branch coverage requirements in some projects
LibbyUX
reviewed
Feb 19, 2026
Contributor
LibbyUX
left a comment
LibbyUX
left a comment
There was a problem hiding this comment.
Summary
Thank you for the chance to review, @axdanbol ! I checked all UIs. Please see my feedback and let me know if you have questions!
ASCT+B Reporter
- The bottom sheet needs a max width
- In the screenshot below, I am viewing palantine tonsil, and I clicked CD38, but the bottom sheet for CD274 popped up. Not sure if this is a data problem or bug that can be addressed.
Figma
EUI
- Text fields in filter menu: The active indicator for Assay types, Consortia, and Tissue data providers shows the error state color instead of our usual active indicator blue, as seen above in the BMI or Age text fields.
9BF8F68B-6273-4527-BDCE-74942A256590.MP4
CDE
- Cell types table not loading
CDE Visualization
- Cell types table not loading
ftu-ui-small-wc
- Using old legend colors for biomarker expression mean
humanatlas.io
- 3D ref page only shows 10th release data in the summary stats table
lod.humanatlas.io
- Rich tooltip using label large instead of label medium for button
- Filter menu padding and margin has been removed
medical-illustration
- The illustration height takes up more than 100% of the viewport
Contributor
Author
|
@LibbyUX I've address most of your feedback but some bugs are not due to the upgrade and I won't address them here. Could you please submit issues for the following problems:
As for the humanatlas.io 3D references we only have data for the 10th release in the repo. Do we have more data somewhere that should be added? And lastly the medical-illustration is supposed to be embedded and take up any available space so taking more than 100% of the viewport is not a bug |
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 20, 2026
* chore: start nx migration * build(global): Move a @swc/helpers to dev dependencies * chore: migrate nx to latest * chore(global): Remove migrations.json * refactor: Build & lint fixes * build(lib:design-system): Fix storybook build I have no idea why the old @types/uuid was breaking storybook... * fix(app:apps.humanatlas.io): Fix missing route, incorrect link, and overlays * fix(app:asctb-reporter): 🐛 Fix bottom sheet data errors, layout, and a bad breadcrumb route * refactor(lib:design-system): Update scrollbar css variables * fix(app:ccf-eui): 🐛 Fix age/bmi sliders affecting other form fields * fix(app:ccf-organ-info): 🐛 Layout fixes * refactor(lib:design-system): Update table scrollbars * build(global): ⬆️ Bump minor and patch version of dependencies * build(global): ⬇️ Downgrade jsdom to a compatible version * test(global): ✅ Pass all tests Also slightly reduce the branch coverage requirements in some projects * chore(global): Lint fix * build(global): ⬆️ Minor dependency upgrades * refactor(global): General fixes 13cde4c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.