Skip to content

Fix getUser() 404 for bot users in PR reviews #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Haarolean wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix getUser() 404 for bot users in PR reviews #2207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/main/java/org/kohsuke/github/GHPullRequestReview.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,7 @@ public Instant getSubmittedAt() {
* the io exception
*/
public GHUser getUser() throws IOException {
if (user != null) {
return owner.root().getUser(user.getLogin());
}
return null;
return owner.root().intern(user);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/kohsuke/github/GHPullRequestReviewComment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ public Side getStartSide() {
* the io exception
*/
public GHUser getUser() throws IOException {
return owner.root().getUser(user.getLogin());
return owner.root().intern(user);
}

/**
Expand Down
Loading