Skip to content

feat Enabled read/write lock for GitHubSanityCachedValue #2201

Open
ravikumar2026 wants to merge 5 commits intohub4j:mainfrom
ravikumar2026:feature/enableLock
Open

feat Enabled read/write lock for GitHubSanityCachedValue #2201
ravikumar2026 wants to merge 5 commits intohub4j:mainfrom
ravikumar2026:feature/enableLock

Conversation

@ravikumar2026
Copy link

Description

feat Enabled read/write lock for GitHubSanityCachedValue 2172

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@ravikumar2026 ravikumar2026 marked this pull request as draft February 22, 2026 03:31
@ravikumar2026 ravikumar2026 marked this pull request as ready for review February 27, 2026 22:46
@ravikumar2026 ravikumar2026 reopened this Feb 27, 2026
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.04%. Comparing base (9152b37) to head (34741e4).

Files with missing lines Patch % Lines
...va/org/kohsuke/github/GitHubSanityCachedValue.java 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2201   +/-   ##
=========================================
  Coverage     85.03%   85.04%           
- Complexity     2499     2504    +5     
=========================================
  Files           237      237           
  Lines          7366     7375    +9     
  Branches        388      392    +4     
=========================================
+ Hits           6264     6272    +8     
  Misses          871      871           
- Partials        231      232    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHubSanityCachedValue can block whole application

2 participants