Skip to content

[Snyk] Fix for 3 vulnerabilities#445

Open
q1blue wants to merge 1 commit intonextfrom
snyk-fix-f7d4e1120de6aa50cd188edaae7082f7
Open

[Snyk] Fix for 3 vulnerabilities#445
q1blue wants to merge 1 commit intonextfrom
snyk-fix-f7d4e1120de6aa50cd188edaae7082f7

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 3 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  803  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  708  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  636  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving three identified vulnerabilities. It achieves this by updating several key dependencies in the package.json file, mitigating risks associated with Regular Expression Denial of Service (ReDoS) and resource allocation issues.

Highlights

  • Vulnerability Fixes: Addressed three security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) in ajv, a medium-severity Allocation of Resources Without Limits or Throttling in qs, and a medium-severity ReDoS in diff.
  • Dependency Updates: Updated several key dependencies in package.json to their latest versions to mitigate the identified vulnerabilities. This includes @nx/eslint, various @storybook/* packages, create-storybook, eslint, and prettier-plugin-merge.
Changelog
  • code/package.json
    • Updated @nx/eslint from 18.0.6 to 19.1.0.
    • Updated @storybook/angular from workspace:* to 3.3.0.
    • Updated @storybook/builder-webpack5 from workspace:* to 6.2.0.
    • Updated @storybook/codemod from workspace:* to 3.0.0.
    • Updated @storybook/core from workspace:* to 3.3.3.
    • Updated @storybook/preset-create-react-app from workspace:* to 1.0.0.
    • Updated @storybook/web-components-webpack5 from workspace:* to 7.0.0.
    • Updated create-storybook from workspace:* to 1.0.0.
    • Updated eslint from ^8.56.0 to ^10.0.0.
    • Updated prettier-plugin-merge from ^0.7.0 to ^0.9.1.
    • Updated storybook from workspace:^ to 0.0.0.
Activity
  • This pull request was automatically created by Snyk to fix 3 identified vulnerabilities.
  • A warning was issued indicating that the yarn.lock file failed to update and requires manual intervention before merging.
  • The PR provides links to detailed Snyk reports for the vulnerabilities and educational resources on how to fix them.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request from Snyk aims to fix security vulnerabilities by upgrading dependencies. However, most of the proposed changes are incorrect for this project's monorepo structure. It replaces workspace:* references with old, pinned versions that are incompatible with the project's current Storybook v8.3, which will lead to build failures. The storybook package version is also incorrectly changed to 0.0.0. These changes should be reverted. The correct way to address vulnerabilities in transitive dependencies is by using the resolutions field in package.json. Additionally, the PR includes major version upgrades for eslint and @nx/eslint which require careful review for breaking changes.

Comment on lines +117 to +123
"@storybook/angular": "3.3.0",
"@storybook/bench": "next",
"@storybook/blocks": "workspace:*",
"@storybook/builder-vite": "workspace:*",
"@storybook/builder-webpack5": "workspace:*",
"@storybook/codemod": "workspace:*",
"@storybook/core": "workspace:*",
"@storybook/builder-webpack5": "6.2.0",
"@storybook/codemod": "3.0.0",
"@storybook/core": "3.3.3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency upgrades from workspace:* to old, pinned versions are incorrect. This monorepo uses Storybook v8.3, but these changes pin packages to much older versions (e.g., v3.3.0, v6.2.0), which will cause major version conflicts and break the project. The workspace:* protocol is essential for maintaining version consistency in this monorepo. To fix the underlying security vulnerabilities in transitive dependencies (like ajv, qs, diff), please add overrides to the resolutions field in package.json instead of changing these direct dependencies.

    "@storybook/angular": "workspace:*",
    "@storybook/bench": "next",
    "@storybook/blocks": "workspace:*",
    "@storybook/builder-vite": "workspace:*",
    "@storybook/builder-webpack5": "workspace:*",
    "@storybook/codemod": "workspace:*",
    "@storybook/core": "workspace:*"

"@storybook/preact-vite": "workspace:*",
"@storybook/preact-webpack5": "workspace:*",
"@storybook/preset-create-react-app": "workspace:*",
"@storybook/preset-create-react-app": "1.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

As with the other @storybook packages, this change is incorrect and should be reverted. Pinning to an old version will break the monorepo. Please use resolutions for transitive vulnerabilities.

    "@storybook/preset-create-react-app": "workspace:*"

"@storybook/web-components": "workspace:*",
"@storybook/web-components-vite": "workspace:*",
"@storybook/web-components-webpack5": "workspace:*",
"@storybook/web-components-webpack5": "7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

As with the other @storybook packages, this change is incorrect and should be reverted. Pinning to an old version will break the monorepo. Please use resolutions for transitive vulnerabilities.

    "@storybook/web-components-webpack5": "workspace:*"

"@vitest/coverage-istanbul": "^2.0.5",
"@vitest/coverage-v8": "^2.0.5",
"create-storybook": "workspace:*",
"create-storybook": "1.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

As with the other @storybook packages, this change is incorrect and should be reverted. Pinning to an old version will break the monorepo. Please use resolutions for transitive vulnerabilities.

    "create-storybook": "workspace:*"

"serve-static": "^1.14.1",
"slash": "^5.0.0",
"storybook": "workspace:^",
"storybook": "0.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Changing the storybook package version from workspace:^ to 0.0.0 is incorrect and will likely break dependency resolution in this monorepo. This change should be reverted.

    "storybook": "workspace:^"

"@chromatic-com/storybook": "^1.6.1",
"@happy-dom/global-registrator": "^14.12.0",
"@nx/eslint": "18.0.6",
"@nx/eslint": "19.1.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a major version upgrade for @nx/eslint from v18 to v19. This may introduce breaking changes related to Nx's ESLint integration. Please review the release notes and test thoroughly to ensure compatibility.

"esbuild-loader": "^4.2.0",
"esbuild-plugin-alias": "^0.2.1",
"eslint": "^8.56.0",
"eslint": "^10.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a major version upgrade for eslint from v8 to v10. This is a significant jump that likely includes breaking changes to ESLint rules and configurations. Please carefully review the ESLint v9 and v10 migration guides and update your configuration accordingly to avoid linting errors or CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants