[Snyk] Security upgrade storybook from 0.0.0-use.local to 0.0.0#441
[Snyk] Security upgrade storybook from 0.0.0-use.local to 0.0.0#441
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-15268416
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security upgrade for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This automated Snyk pull request attempts to address a security vulnerability by modifying the storybook dependency. However, the change in code/lib/create-storybook/package.json from "storybook": "workspace:*" to "storybook": "0.0.0" is incorrect for this monorepo structure. The workspace:* protocol is crucial for linking local packages in a Yarn workspace. Replacing it with 0.0.0 will likely break the create-storybook package. I've added a critical comment suggesting to revert this change. The underlying vulnerability should be addressed, but not with this automated modification.
| "prompts": "^2.4.0", | ||
| "semver": "^7.3.7", | ||
| "storybook": "workspace:*", | ||
| "storybook": "0.0.0", |
There was a problem hiding this comment.
This change from workspace:* to 0.0.0 for the storybook dependency appears to be incorrect and will likely break the create-storybook package. The workspace:* protocol is used by Yarn workspaces to link to the local storybook package within this monorepo. Changing it to 0.0.0 will prevent it from resolving to the correct local package.
While the intention to fix a security vulnerability is valid, this automated change by Snyk seems to have misinterpreted the version. This change should be reverted to workspace:*.
| "storybook": "0.0.0", | |
| "storybook": "workspace:*", |
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-15268416
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/lib/create-storybook/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling