Skip to content

[Snyk] Security upgrade storybook from 0.0.0-use.local to 0.0.0#441

Open
q1blue wants to merge 2 commits intonextfrom
snyk-fix-b87b51abf32d2afd2399a3ead964fb11
Open

[Snyk] Security upgrade storybook from 0.0.0-use.local to 0.0.0#441
q1blue wants to merge 2 commits intonextfrom
snyk-fix-b87b51abf32d2afd2399a3ead964fb11

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/lib/create-storybook/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates a critical security upgrade for the storybook dependency, aiming to mitigate a known vulnerability. The primary impact is an enhanced security posture for the project, achieved through a targeted dependency version bump. Reviewers should focus on the implications of the version change and the manual yarn.lock update requirement.

Highlights

  • Security Upgrade: This pull request, automatically generated by Snyk, addresses a security vulnerability by upgrading the storybook dependency.
  • Dependency Version Update: The storybook dependency in code/lib/create-storybook/package.json has been updated from workspace:* to 0.0.0.
  • Vulnerability Fixed: The upgrade fixes a medium-severity 'Allocation of Resources Without Limits or Throttling' vulnerability (SNYK-JS-QS-15268416).
  • Yarn Zero-Installs Note: Users of Yarn's zero-installs feature are advised to run yarn to update the .yarn/cache/ directory, as this PR does not update it automatically.
  • Manual yarn.lock Update Required: Snyk reported a failure to update yarn.lock, requiring a manual update before merging.
Changelog
  • code/lib/create-storybook/package.json
    • Updated the storybook dependency version from workspace:* to 0.0.0.
Activity
  • This pull request was automatically created by Snyk to address a security vulnerability.
  • Snyk identified a medium-severity vulnerability (SNYK-JS-QS-15268416) related to 'Allocation of Resources Without Limits or Throttling'.
  • Snyk attempted to update yarn.lock but reported a failure, indicating a manual update is needed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This automated Snyk pull request attempts to address a security vulnerability by modifying the storybook dependency. However, the change in code/lib/create-storybook/package.json from "storybook": "workspace:*" to "storybook": "0.0.0" is incorrect for this monorepo structure. The workspace:* protocol is crucial for linking local packages in a Yarn workspace. Replacing it with 0.0.0 will likely break the create-storybook package. I've added a critical comment suggesting to revert this change. The underlying vulnerability should be addressed, but not with this automated modification.

"prompts": "^2.4.0",
"semver": "^7.3.7",
"storybook": "workspace:*",
"storybook": "0.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change from workspace:* to 0.0.0 for the storybook dependency appears to be incorrect and will likely break the create-storybook package. The workspace:* protocol is used by Yarn workspaces to link to the local storybook package within this monorepo. Changing it to 0.0.0 will prevent it from resolving to the correct local package.

While the intention to fix a security vulnerability is valid, this automated change by Snyk seems to have misinterpreted the version. This change should be reverted to workspace:*.

Suggested change
"storybook": "0.0.0",
"storybook": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants