[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 6.2.0#439
[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 6.2.0#439
Conversation
…ulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, addresses critical security vulnerabilities by upgrading the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request incorrectly attempts to resolve security vulnerabilities by pinning a workspace dependency, @storybook/builder-webpack5, to an outdated version (6.2.0). In this monorepo, internal dependencies should use the workspace: protocol to maintain version consistency and build integrity. Downgrading this package from the current workspace version (8.3.0-beta.3) to 6.2.0 will break the build and cause significant compatibility issues. Security fixes should be applied to the builder package directly or via Yarn resolutions at the root level.
| }, | ||
| "dependencies": { | ||
| "@storybook/builder-webpack5": "workspace:*", | ||
| "@storybook/builder-webpack5": "6.2.0", |
There was a problem hiding this comment.
Pinning @storybook/builder-webpack5 to version 6.2.0 is a critical error in a monorepo context. This package is a local workspace dependency and must use the workspace:* protocol to stay in sync with the rest of the repository (currently at 8.3.0-beta.3). Forcing an old version breaks the workspace link and will lead to build failures and runtime incompatibilities. Transitive vulnerabilities should be addressed within the builder's own package.json or through root-level resolutions.
| "@storybook/builder-webpack5": "6.2.0", | |
| "@storybook/builder-webpack5": "workspace:*", |
…ulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/web-components-webpack5/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-AJV-15274295
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling