Skip to content

[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 6.2.0#439

Open
q1blue wants to merge 2 commits intonextfrom
snyk-fix-b65d42cb60512b4f0ef4efbb6501dcd7
Open

[Snyk] Security upgrade @storybook/builder-webpack5 from 0.0.0-use.local to 6.2.0#439
q1blue wants to merge 2 commits intonextfrom
snyk-fix-b65d42cb60512b4f0ef4efbb6501dcd7

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/web-components-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, addresses critical security vulnerabilities by upgrading the @storybook/builder-webpack5 dependency. The upgrade targets a high-severity Regular Expression Denial of Service (ReDoS) and a medium-severity Allocation of Resources Without Limits or Throttling. While the package.json has been updated, manual intervention is required to update the yarn.lock file, particularly for projects using Yarn's zero-install feature, to ensure the fix is fully applied.

Highlights

  • Security Upgrade: Upgraded the @storybook/builder-webpack5 dependency from workspace:* to 6.2.0 to mitigate two identified vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) and a medium-severity Allocation of Resources Without Limits or Throttling.
  • Automated Remediation: This pull request was automatically generated by Snyk to apply the necessary security fix.
  • Manual Intervention Required: The yarn.lock file was not automatically updated and requires manual resolution before merging, which is particularly important for projects utilizing Yarn's zero-installs feature.
Changelog
  • code/frameworks/web-components-webpack5/package.json
    • Updated the version of @storybook/builder-webpack5 from workspace:* to 6.2.0.
Activity
  • This pull request was automatically created by Snyk to propose a security upgrade.
  • Snyk identified two vulnerabilities: a high-severity ReDoS and a medium-severity resource allocation issue.
  • Snyk noted that the yarn.lock file failed to update and requires manual resolution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request incorrectly attempts to resolve security vulnerabilities by pinning a workspace dependency, @storybook/builder-webpack5, to an outdated version (6.2.0). In this monorepo, internal dependencies should use the workspace: protocol to maintain version consistency and build integrity. Downgrading this package from the current workspace version (8.3.0-beta.3) to 6.2.0 will break the build and cause significant compatibility issues. Security fixes should be applied to the builder package directly or via Yarn resolutions at the root level.

},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "6.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @storybook/builder-webpack5 to version 6.2.0 is a critical error in a monorepo context. This package is a local workspace dependency and must use the workspace:* protocol to stay in sync with the rest of the repository (currently at 8.3.0-beta.3). Forcing an old version breaks the workspace link and will lead to build failures and runtime incompatibilities. Transitive vulnerabilities should be addressed within the builder's own package.json or through root-level resolutions.

Suggested change
"@storybook/builder-webpack5": "6.2.0",
"@storybook/builder-webpack5": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants