[Snyk] Security upgrade @storybook/core-webpack from 0.0.0-use.local to 7.0.0#436
[Snyk] Security upgrade @storybook/core-webpack from 0.0.0-use.local to 7.0.0#436
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security upgrade, initiated by Snyk, to mitigate a high-severity Regular Expression Denial of Service vulnerability. It updates a core Storybook dependency to a secure version, ensuring the project's resilience against this specific threat. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to fix a security vulnerability by upgrading @storybook/core-webpack. However, the proposed change is incorrect for this monorepo setup. It replaces the workspace:* reference with a hardcoded version 7.0.0. This is a major version downgrade from the current workspace version 8.3.0-beta.3 and will likely cause significant breakages by pulling an outdated package from the public registry instead of using the local one. This PR should not be merged in its current state. The underlying vulnerability should be assessed against the current 8.3.0-beta.3 version of the package.
| }, | ||
| "dependencies": { | ||
| "@storybook/core-webpack": "workspace:*", | ||
| "@storybook/core-webpack": "7.0.0", |
There was a problem hiding this comment.
This change incorrectly pins @storybook/core-webpack to 7.0.0, replacing the workspace:* reference. This is a major version downgrade from the current workspace version (8.3.0-beta.3) and will cause an outdated package to be pulled from the public registry instead of using the local one. This will likely break the build or cause runtime issues. Please revert this change to use the workspace version.
"@storybook/core-webpack": "workspace:*"
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/presets/html-webpack/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-AJV-15274295
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)