Skip to content

[Snyk] Security upgrade @storybook/core from 0.0.0-use.local to 3.3.3#433

Open
q1blue wants to merge 1 commit intonextfrom
snyk-fix-cd52cb5a697dcc73ab1775843f33e70b
Open

[Snyk] Security upgrade @storybook/core from 0.0.0-use.local to 3.3.3#433
q1blue wants to merge 1 commit intonextfrom
snyk-fix-cd52cb5a697dcc73ab1775843f33e70b

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 14, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/lib/codemod/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the @storybook/core dependency. The update addresses a medium-severity vulnerability related to resource allocation, ensuring a more secure and stable development environment.

Highlights

  • Security Upgrade: Automated upgrade of the @storybook/core dependency from 0.0.0-use.local to 3.3.3 to address a security vulnerability.
  • Vulnerability Addressed: Fixes a medium-severity 'Allocation of Resources Without Limits or Throttling' vulnerability (SNYK-JS-QS-15268416) with a score of 62.
  • Yarn Zero-Install Note: Includes a warning for Yarn zero-install users, advising them to run yarn to update the .yarn/cache/ directory.
  • Manual yarn.lock Update Required: Notes that the yarn.lock file failed to update automatically and requires manual intervention before merging.
Changelog
  • code/lib/codemod/package.json
    • Updated the @storybook/core dependency version.
Activity
  • This pull request was automatically created by Snyk to address security vulnerabilities.
  • It proposes an upgrade for @storybook/core to mitigate a medium-severity issue.
  • A warning is included regarding manual yarn.lock update and zero-install considerations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix a security vulnerability by upgrading @storybook/core. However, the proposed change is a massive downgrade from the workspace version (v8.3.0-beta.3) to v3.3.3. This will almost certainly break the build and functionality due to major API changes between these versions. The correct approach would be to update the vulnerable transitive dependency (qs) or update @storybook/core to a newer version that resolves the issue, rather than performing a drastic downgrade. I have added a critical comment to revert this change.

"@babel/preset-env": "^7.24.4",
"@babel/types": "^7.24.0",
"@storybook/core": "workspace:*",
"@storybook/core": "3.3.3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change downgrades @storybook/core from the current workspace version (v8.3.0-beta.3) to a very old version (v3.3.3). This is a significant downgrade that will almost certainly cause breakages, as the codemods in this package rely on APIs from @storybook/core which have changed drastically between v3 and v8.

The goal is to fix a vulnerability in the qs package, but this is not the correct approach. Instead of downgrading, the qs dependency should be updated, or @storybook/core should be updated to a version that includes a non-vulnerable version of qs.

Pinning to an old version also breaks the monorepo convention of using workspace:* to refer to local packages. This change should be reverted.

Suggested change
"@storybook/core": "3.3.3",
"@storybook/core": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants