[Snyk] Security upgrade @storybook/core from 0.0.0-use.local to 3.3.3#433
[Snyk] Security upgrade @storybook/core from 0.0.0-use.local to 3.3.3#433
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-15268416
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, attempts to fix a security vulnerability by upgrading @storybook/core. However, the proposed change is a massive downgrade from the workspace version (v8.3.0-beta.3) to v3.3.3. This will almost certainly break the build and functionality due to major API changes between these versions. The correct approach would be to update the vulnerable transitive dependency (qs) or update @storybook/core to a newer version that resolves the issue, rather than performing a drastic downgrade. I have added a critical comment to revert this change.
| "@babel/preset-env": "^7.24.4", | ||
| "@babel/types": "^7.24.0", | ||
| "@storybook/core": "workspace:*", | ||
| "@storybook/core": "3.3.3", |
There was a problem hiding this comment.
This change downgrades @storybook/core from the current workspace version (v8.3.0-beta.3) to a very old version (v3.3.3). This is a significant downgrade that will almost certainly cause breakages, as the codemods in this package rely on APIs from @storybook/core which have changed drastically between v3 and v8.
The goal is to fix a vulnerability in the qs package, but this is not the correct approach. Instead of downgrading, the qs dependency should be updated, or @storybook/core should be updated to a version that includes a non-vulnerable version of qs.
Pinning to an old version also breaks the monorepo convention of using workspace:* to refer to local packages. This change should be reverted.
| "@storybook/core": "3.3.3", | |
| "@storybook/core": "workspace:*", |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/lib/codemod/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling