fix(fish): improve shell completion compatibility and namespacing#1813
Open
SpiliosDimakopoulos wants to merge 1 commit intohttpie:masterfrom
Open
fix(fish): improve shell completion compatibility and namespacing#1813SpiliosDimakopoulos wants to merge 1 commit intohttpie:masterfrom
SpiliosDimakopoulos wants to merge 1 commit intohttpie:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses minor issues in the Fish completion script to ensure better compatibility and avoid potential naming collisions.
Changes
__fish_http_verify_optionsto__fish_httpie_verify_optionsto prevent conflicts with other HTTP-related plugins.echo -ewithprintffor better string formatting, asecho -ebehavior can vary between shell versions/environments.Validation
Verified the syntax using
fish --no-execute extras/httpie-completion.fishwithin a Fish environment. No syntax errors were found.