Skip to content

fix(fish): improve shell completion compatibility and namespacing#1813

Open
SpiliosDimakopoulos wants to merge 1 commit intohttpie:masterfrom
SpiliosDimakopoulos:fix/fish-completion-bugs
Open

fix(fish): improve shell completion compatibility and namespacing#1813
SpiliosDimakopoulos wants to merge 1 commit intohttpie:masterfrom
SpiliosDimakopoulos:fix/fish-completion-bugs

Conversation

@SpiliosDimakopoulos
Copy link
Copy Markdown

Description

This PR addresses minor issues in the Fish completion script to ensure better compatibility and avoid potential naming collisions.

Changes

  • Namespacing: Renamed __fish_http_verify_options to __fish_httpie_verify_options to prevent conflicts with other HTTP-related plugins.
  • Compatibility: Replaced echo -e with printf for better string formatting, as echo -e behavior can vary between shell versions/environments.
  • Consistency: Fixed a call-site mismatch where the old function name was still being referenced.

Validation

Verified the syntax using fish --no-execute extras/httpie-completion.fish within a Fish environment. No syntax errors were found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant