Skip to content

replaced poor-style eval() call with getattr() and method call #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mark-summerfield wants to merge 3 commits into
base: master
Choose a base branch
from
Open

replaced poor-style eval() call with getattr() and method call #26

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa0f637
replaced poor-style eval() call with getattr() and method call
mark-summerfield Jul 21, 2023
564d942
fixed memory size checks
mark-summerfield Jul 21, 2023
1f5edef
used an f-string rather than +
mark-summerfield Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion m6502/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,9 @@ def execute(self, cycles: int = 0) -> None:
"""
while (self.cycles < cycles) or (cycles == 0):
opcode = self.fetch_byte()
eval("self.ins_" + self.OPCODES[opcode] + "_" + self.ADDRESSING[opcode] + "()") # noqa: PLW0123
name = "ins_" + self.OPCODES[opcode] + "_" + self.ADDRESSING[opcode]
Copy link
Copy Markdown

@pavelo22 pavelo22 Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about building the name string with f-strings?

Copy link
Copy Markdown
Author

@mark-summerfield mark-summerfield Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now done it that way.

method = getattr(self, name)
method()

def ins_nop_imp(self) -> None:
"""
Expand Down