Skip to content

chore: remove datasets API and related job types#66

Merged
zfarrell merged 2 commits into
mainfrom
openapi-update-27851776712
Jun 19, 2026
Merged

chore: remove datasets API and related job types#66
zfarrell merged 2 commits into
mainfrom
openapi-update-27851776712

Conversation

@hotdata-automation

Copy link
Copy Markdown
Contributor

Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www.hotdata.dev/pull/233

Comment thread src/apis/mod.rs
pub mod connections_api;
pub mod database_context_api;
pub mod databases_api;
pub mod datasets_api;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking — build break. Removing the datasets_api module (and the dataset models / dataset-index ops) leaves the hand-written wrapper layer dangling. These files are not regenerated by the OpenAPI generator and still reference the deleted symbols, so the crate will fail to compile:

  • src/resources.rsDatasetsApi (lines 20–84) calls apis::datasets_api::{create_dataset, get_dataset, list_datasets, update_dataset, delete_dataset, list_dataset_versions} and uses models::{CreateDatasetRequest, CreateDatasetResponse, GetDatasetResponse, ListDatasetsResponse, UpdateDatasetRequest, UpdateDatasetResponse, ListDatasetVersionsResponse} — all deleted (E0433/E0412).
  • src/resources.rs:426–449create_dataset_index/list_dataset_indexes/delete_dataset_index call apis::indexes_api::{create_dataset_index, list_dataset_indexes, delete_dataset_index} and their *Error enums, all removed from indexes_api.rs in this PR.
  • src/resources.rs:867–890 — unit tests construct DatasetsApi::new(&config).
  • src/client.rs:726–727pub fn datasets(&self) -> crate::resources::DatasetsApi<'_>.
  • src/lib.rs:52 — re-exports DatasetsApi.

The hand-written wrapper/re-export layer must be updated in the same change to drop these dataset entry points (and src/field.rs doc references to UpdateDatasetRequest).

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Blocking Issues

This auto-generated OpenAPI update deletes the entire datasets_api module, all dataset models, and the dataset-index operations from indexes_api.rs, but the hand-written wrapper/re-export layer is not regenerated and still references the deleted symbols. The crate will not compile.

  • src/resources.rs:20-84DatasetsApi wrapper calls apis::datasets_api::{create_dataset, get_dataset, list_datasets, update_dataset, delete_dataset, list_dataset_versions} and references models::{CreateDatasetRequest, CreateDatasetResponse, GetDatasetResponse, ListDatasetsResponse, UpdateDatasetRequest, UpdateDatasetResponse, ListDatasetVersionsResponse} — all deleted by this PR (unresolved module / type errors).
  • src/resources.rs:426-449create_dataset_index / list_dataset_indexes / delete_dataset_index call apis::indexes_api::{create_dataset_index, list_dataset_indexes, delete_dataset_index} and their CreateDatasetIndexError / ListDatasetIndexesError / DeleteDatasetIndexError enums, all removed from indexes_api.rs here.
  • src/resources.rs:867-890 — unit tests instantiate DatasetsApi::new(&config).
  • src/client.rs:726-727pub fn datasets(&self) returns crate::resources::DatasetsApi<'_>.
  • src/lib.rs:52 — re-exports DatasetsApi.
  • src/field.rs:4,21,23 — doc examples reference the deleted models::UpdateDatasetRequest.

Action Required

Update the hand-written wrapper layer in the same change so it no longer depends on the removed generated code:

  • Remove the DatasetsApi resource handle and its tests from src/resources.rs, plus the dataset-index methods (create_dataset_index, list_dataset_indexes, delete_dataset_index).
  • Remove Client::datasets() from src/client.rs and the DatasetsApi re-export from src/lib.rs.
  • Fix the src/field.rs doc example to use a model that still exists.
  • Confirm cargo build and cargo test pass before merge.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycle 1 blocking issue (dangling dataset references in the hand-written wrapper layer) is resolved — src/resources.rs, src/client.rs, src/lib.rs, and src/field.rs were updated to drop all dataset entry points, and no references to deleted symbols remain in src/, tests/, or examples/.

@zfarrell zfarrell merged commit 7634bf3 into main Jun 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant